"Non-Error exception captured with keys: [...]" due to invalid error instanceof check

[theofidry]

This issue is a follow up of #6332. It has been close since at that time I thought this was an Angular package only issue, but it looks like the is also upstream.

From what I can see, this is caused by https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/src/eventbuilder.ts#L228-L230.

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Self-hosted/on-premise

Which package are you using?

@sentry/angular

SDK Version

7.4.30

Framework Version

Angular 13.3 & Ionic 5

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

throw {
  name: 'ErrorLikeObject',
  message: 'ErrorLikeObject message',
};

Expected Result

A Sentry record showing something along the lines of:

ErrorLikeObject
ErrorLikeObject message

Actual Result

The current Sentry record showing something along the lines of:

captureException
Non-Error exception captured with keys: message, name

[AbhiPrasad]

Hey @theofidry thanks for writing in again! We can probably make a similar change to the core logic here to capture this as a proper error. Backlogging, but PRs are welcome!

[AbhiPrasad]

This has been fixed in browser as of v7.57.0 of the JavaScript SDKs, but it is still a problem in Node.

[AbhiPrasad]

ref

• https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md#7570
• feat(browser): Better event name handling for non-Error objects #8374
• feat(core): Add ServerRuntimeClient #8930 (comment)

[AbhiPrasad]

Improvements released with with https://github.com/getsentry/sentry-javascript/releases/tag/7.70.0 of the Node SDK. Please let us know if you have any feedback!