diff --git a/CODEOWNERS b/CODEOWNERS index 37de5c8d..ad60a413 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -15,22 +15,24 @@ /topics/processed-profiles.yaml @getsentry/owners-snuba @getsentry/profiling /topics/profiles-call-tree.yaml @getsentry/owners-snuba @getsentry/profiling /topics/group-attributes.yaml @getsentry/owners-snuba @getsentry/issues -/topics/snuba-spans.yaml @getsentry/owners-snuba +/topics/snuba-spans.yaml @getsentry/owners-snuba @getsentry/profiling # Topics produced to by Snuba /topics/shared-resources-usage.yaml @getsentry/owners-snuba @getsentry/data # Schemas -/schemas/profile-metadata.v1.schema.json @getsentry/profiling -/schemas/profile-functions.v1.schema.json @getsentry/profiling -/schemas/group-attributes.v1.schema.json @getsentry/issues +/schemas/profile-metadata.v1.schema.json @getsentry/owners-snuba @getsentry/profiling +/schemas/profile-functions.v1.schema.json @getsentry/owners-snuba @getsentry/profiling +/schemas/group-attributes.v1.schema.json @getsentry/owners-snuba @getsentry/issues /schemas/ingest-spans.v1.schema.json @getsentry/team-starfish +/schemas/snuba-spans.v1.schema.json @getsentry/owners-snuba @getsentry/profiling # Examples -/examples/profile-metadata/ @getsentry/profiling -/examples/profile-functions/ @getsentry/profiling -/examples/group-attributes/ @getsentry/issues -/examples/ingest-spans/ @getsentry/team-starfish +/examples/profile-metadata/ @getsentry/owners-snuba @getsentry/profiling +/examples/profile-functions/ @getsentry/owners-snuba @getsentry/profiling +/examples/group-attributes/ @getsentry/owners-snuba @getsentry/issues +/examples/ingest-spans/ @getsentry/owners-snuba @getsentry/team-starfish +/examples/snuba-spans/ @getsentry/owners-snuba @getsentry/profiling # Internal Snuba topics /topics/snuba-queries.yaml @getsentry/owners-snuba diff --git a/README.md b/README.md index 5e0f4502..cfa15f50 100644 --- a/README.md +++ b/README.md @@ -138,3 +138,5 @@ command is `make install-py-dev`. All topics definitions, schemas and examples should have a defined owner or multiple owners if shared. The CODEOWNERS file should be updated with this information whenever new schemas and topics are added. + +Review is only required from one team/owner, not from all of them.