From 16a14aeb1d58449b70a80d88f01697b5d0d35c21 Mon Sep 17 00:00:00 2001
From: Jack Zhang <jack.zhang@sentry.io>
Date: Wed, 20 Dec 2023 17:39:15 -0500
Subject: [PATCH 1/2] add tests for root owners finding

---
 enhancers_test.go | 123 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 123 insertions(+)

diff --git a/enhancers_test.go b/enhancers_test.go
index 7af41ad..0a54a95 100644
--- a/enhancers_test.go
+++ b/enhancers_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 
 	"github.com/getsentry/sentry-go"
+	v1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes/fake"
@@ -96,3 +97,125 @@ func TestRunEnhancers(t *testing.T) {
 		t.Errorf("For event message, received \"%s\", wanted \"%s\"", event.Message, expectedMessage)
 	}
 }
+
+func TestFindRootOwner(t *testing.T) {
+	// Create empty context
+	ctx := context.Background()
+	// Create simple fake client
+	fakeClientset := fake.NewSimpleClientset()
+
+	// Create pod object with no owning references
+	podObj := &corev1.Pod{
+		TypeMeta: metav1.TypeMeta{
+			Kind: "Pod",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "TestFindRootOwnerPod",
+			Namespace: "TestFindRootOwnerNamespace",
+		},
+		Spec: corev1.PodSpec{
+			NodeName: "TestFindRootOwnerNode",
+		},
+	}
+
+	_, err := fakeClientset.CoreV1().Pods("TestFindRootOwnerNamespace").Create(context.TODO(), podObj, metav1.CreateOptions{})
+	if err != nil {
+		t.Fatalf("Error injecting pod add: %v", err)
+	}
+
+	ctx = setClientsetOnContext(ctx, fakeClientset)
+
+	// Check the findRootOwners function does not return a slice
+	// with pod which is the object passed in since it has no
+	// owning references
+	rootOwners, err := findRootOwners(ctx, &KindObjectPair{
+		kind:   "Pod",
+		object: podObj,
+	})
+	if err != nil {
+		t.Errorf("Function returned error: %#v", err)
+	}
+	if len(rootOwners) != 0 {
+		t.Errorf("Function did not return empty slice as expected")
+	}
+
+}
+
+func TestOwnerRefDFS(t *testing.T) {
+
+	// Create empty context
+	ctx := context.Background()
+	// Create simple fake client
+	fakeClientset := fake.NewSimpleClientset()
+
+	// Create pod object with replicaset as owning reference
+	podObj := &corev1.Pod{
+		TypeMeta: metav1.TypeMeta{
+			Kind: "Pod",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "TestOwnerRefDFSPod",
+			Namespace: "TestOwnerRefDFSNamespace",
+			OwnerReferences: []metav1.OwnerReference{
+				{
+					Kind: "ReplicaSet",
+					Name: "TestOwnerRefDFSReplicaset",
+				},
+			},
+		},
+		Spec: corev1.PodSpec{
+			NodeName: "TestOwnerRefDFSNode",
+		},
+	}
+
+	var replicas int32 = 3
+	replicasetObj := &v1.ReplicaSet{
+		TypeMeta: metav1.TypeMeta{
+			Kind: "ReplicaSet",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "TestOwnerRefDFSReplicaset",
+			Namespace: "TestOwnerRefDFSNamespace",
+		},
+		Spec: v1.ReplicaSetSpec{
+			Replicas: &replicas,
+		},
+		Status: v1.ReplicaSetStatus{
+			Replicas: replicas,
+		},
+	}
+
+	_, err := fakeClientset.CoreV1().Pods("TestOwnerRefDFSNamespace").Create(context.TODO(), podObj, metav1.CreateOptions{})
+	if err != nil {
+		t.Fatalf("Error injecting pod add: %v", err)
+	}
+	_, err = fakeClientset.AppsV1().ReplicaSets("TestOwnerRefDFSNamespace").Create(context.TODO(), replicasetObj, metav1.CreateOptions{})
+	if err != nil {
+		t.Fatalf("Error injecting replicaset add: %v", err)
+	}
+
+	ctx = setClientsetOnContext(ctx, fakeClientset)
+
+	rootOwners, err := ownerRefDFS(ctx, &KindObjectPair{
+		kind:   podObj.Kind,
+		object: podObj,
+	})
+	if err != nil {
+		t.Errorf("the DFS produced an error: %#v", err)
+	}
+	if rootOwners == nil {
+		t.Errorf("Failed to return a slice of root owners: %#v", err)
+		return
+	}
+	if len(rootOwners) != 1 {
+		t.Errorf("Failed to produce correct number of root owners")
+		return
+	}
+	if rootOwners[0].kind != replicasetObj.Kind {
+		t.Errorf("The root owner's kind is incorrect")
+	}
+	if rootOwners[0].object.GetName() != replicasetObj.Name {
+		t.Errorf("The root owner's object is incorrect")
+	}
+
+}

From 3ae9f3f7d378690e611910a170d73d29e61110d3 Mon Sep 17 00:00:00 2001
From: Jack Zhang <jack.zhang@sentry.io>
Date: Thu, 21 Dec 2023 11:51:13 -0500
Subject: [PATCH 2/2] linting

---
 enhancers_test.go | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/enhancers_test.go b/enhancers_test.go
index dcac72d..8abf2fd 100644
--- a/enhancers_test.go
+++ b/enhancers_test.go
@@ -137,11 +137,9 @@ func TestFindRootOwner(t *testing.T) {
 	if len(rootOwners) != 0 {
 		t.Errorf("Function did not return empty slice as expected")
 	}
-
 }
 
 func TestOwnerRefDFS(t *testing.T) {
-
 	// Create empty context
 	ctx := context.Background()
 	// Create simple fake client
@@ -216,5 +214,4 @@ func TestOwnerRefDFS(t *testing.T) {
 	if rootOwners[0].object.GetName() != replicasetObj.Name {
 		t.Errorf("The root owner's object is incorrect")
 	}
-
 }