Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keep-Alive header if keep_alive is on #3532

Open
sentrivana opened this issue Sep 13, 2024 · 0 comments
Open

Add Keep-Alive header if keep_alive is on #3532

sentrivana opened this issue Sep 13, 2024 · 0 comments
Labels
Component: Transport Dealing with the transport

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Sep 13, 2024 •
edited
Loading

If keep_alive is set to True, we currently set a bunch of TCP socket options. There are also respective HTTP headers (Connection and Keep-Alive) that we don't set.

Apparently HTTP/1.1 keeps connections open by default and the Connection header is not needed. However, a reasonable Keep-Alive that is in line with the timeout in the socket options would be good to add.
@sentrivana sentrivana added the Component: Transport Dealing with the transport label Sep 13, 2024
@sentrivana sentrivana changed the title Add Connection and Keep-Alive headers if keep_alive is on Add Keep-Alive header if keep_alive is on Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Transport Dealing with the transport
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sentrivana