-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS build: Sentry fails with RN 0.75 #4036
Comments
Same. I checked it and the Sentry CLI seems to overwrite the $NODE_BINARY env variable. I added a A workaround for now (at least for me) is, to patch react-native-xcode.sh and replace the env var with the (locally correct) hard-coded node path (i.e. just "node" or "/usr/local/bin/node" or whatever). |
Hi @theJovian and @sbeigel, thank you for the report, the React Native new xcode script is currently not compatible with the sentry stript out of the box. We will fix this soon. You can use the following workaround, manually set the new React Native config command. export CONFIG_CMD="$NODE_BINARY $NODE_ARGS $REACT_NATIVE_PATH/cli.js config"
export CONFIG_APP="${CONFIG_CMD}" |
We will need to investigate why https://github.com/getsentry/sentry-cli/blob/a2a4d543f4d191db553f7b1b3385c5cd0c9cfefd/src/commands/react_native/xcode.rs#L425 doesn't execute the https://github.com/getsentry/sentry-cli/blob/a2a4d543f4d191db553f7b1b3385c5cd0c9cfefd/src/commands/react_native/xcode.rs#L425 |
I see one more issue with |
@xuanmai-agilityio Has this change with upgrade to 0.75? And the workaround from #4036 (comment) doesn't work? |
same issue |
@krystofwoldrich Do you mean to update the |
Based on this comment: #4036 (comment) We got something like this and is working for us: Maybe we are missing $NODE_ARGS though |
@xuanmai-agilityio @theJovian Yes, both looks good. The missing |
I've update the code snippet. This is now easy copy paste. export CONFIG_CMD="$NODE_BINARY $NODE_ARGS $REACT_NATIVE_PATH/cli.js config"
export CONFIG_APP="${CONFIG_CMD}" The snippet will work with the future fix in the RN script. As well as the Sentry CLI fix. |
@xuanmai-agilityio Do you get any errors? |
Would you anticipate this working within a CircleCI environment during build? |
Report of this still happening with 5.31.0 (with new arch enabled): #4052 |
the same error in the linked issue above persists with RN 0.75.2, sentry 5.31.0 with the old architecture built with github actions. safe to say sentry is still not compatible with RN 0.75 right now
|
got the same issue |
Got this issue when running with updated
|
I'm not a sentry developer, but to me it looks like this issue is fixed by #2131 but this fix is NOT released yet and NEITHER included in @sentry/react-native. So we have to wait for that (and use custom patches until it's released). |
@sbeigel that's correct, the fix needs to be released with |
@xuanmai-agilityio For monorepos you will need to adjust the path to the Based on the error you got, something like this should work.
|
Fix released in 5.31.1 |
I am getting still facing an error on 5.31.1.
These are my project versions (I'm not using expo):
These are the content from Bundle React Native code and Images (auto-generated):
and these are in Upload Debug Symbols to Sentry (also auto-generated):
The issue doesn't exist if I remove Sentry. Is this related to the parent issue? or any work arounds? |
It seems to work with pnpm monorepo + React Native 0.75.2 + sentry 5.31.1. Not finding the above jsbundle seems to be a different issue!
How about trying the above? |
@jieey1140 The script you provided worked for me. Thank you! 🥳 |
Still getting this issue:
I've now wasted many hours trying to debug. My next step is removing sentry altogether. Please advise. |
Hi @chrisfinch, I'm sorry to hear that. If you are running in the auto upload issue, you can always use Based on the output, the The script uses the Node JS resolution to get the binary You can try to run |
OS:
Platform:
SDK:
@sentry/react-native
(>= 1.0.0)react-native-sentry
(<= 0.43.2)SDK version: 5.30.0
react-native
version: 0.75.1Are you using Expo?
Are you using sentry.io or on-premise?
If you are using sentry.io, please post a link to your issue so we can take a look: N/A
Configuration:
(
@sentry/react-native
)I have the following issue:
The following error appears when building for ios in release
Steps to reproduce:
Actual result:
Build fails
Expected result:
Build succeeds
The text was updated successfully, but these errors were encountered: