-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically import package.json
instead of JSON.parse
ing it
#561
Comments
It's kinda wild that solution was accepted, I'd rather make some plugin for vscode where it parses some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Alternative issue title: There's no such thing as stability in JS-land
Looks like Bun is going to permit comments in
package.json
(oven-sh/bun#10287). This will break our wizard which currently reads users'package.json
files and parses them withJSON.parse
.JSON.parse
throws when it encounters comments. We catch this in the wizard but this obviously degrades the setup flow (iirc we even early return in some cases, e.g. sourcemaps wizard).If they go through with this change, we need to move to an alternative parsing method. I guess we could try to dynamically
import
the file instead but iirc we tried this before and ran into some issues. Opening this issue to track the problem.Prio-wise, I'd argue this is low because:
Until we get to this, we'll need to tell folks to not add comments into their
package.json
.The text was updated successfully, but these errors were encountered: