Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert dsn: process.env.NEXT_PUBLIC_SENTRY_DSN || 'actualdsn' instead of just the dsn #602

Open
lforst opened this issue Jun 21, 2024 · 1 comment
Assignees

Comments

@lforst
Copy link
Member

lforst commented Jun 21, 2024

That makes it a) easier to configure the DSN b) easier for people to understand how to parameterize the DSN properly.

@lforst lforst self-assigned this Jun 21, 2024
@lforst
Copy link
Member Author

lforst commented Jun 25, 2024

When I sat down and implemented this, I realized this might be a really bad idea.

So basically we would be adding

dsn: process.env.NEXT_PUBLIC_SENTRY_DSN || "${dsn}"

That makes it very easy for people to configure the DSN via an env var, however, when they had NEXT_PUBLIC_SENTRY_DSN previously set to something other than the dsn that was inserted, they are gonna have a VERY bad time because their events won't show up where they would expect them to.

Gonna put this off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant