Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Dependency punycode #666

Open
Lms24 opened this issue Sep 6, 2024 · 2 comments
Open

Outdated Dependency punycode #666

Lms24 opened this issue Sep 6, 2024 · 2 comments

Comments

@Lms24
Copy link
Member

Lms24 commented Sep 6, 2024

Reported internally, we use an outdated dependency:

Image

Dependency chain:

=> Found "punycode@2.1.1"
info Reasons this module exists
   - "eslint#ajv#uri-js" depends on it
   - Hoisted from "eslint#ajv#uri-js#punycode"
@Lms24
Copy link
Member Author

Lms24 commented Sep 6, 2024

Bumping eslint should do the trick. I'm gonna give this a quick try

@Lms24
Copy link
Member Author

Lms24 commented Sep 6, 2024

So this was a bit tricky to determine but I think I now got to the botttom of this warning:

Image

whatwg-url imports the node native version of punycode which is deprecated. Dependency tree of whatwg-url

└─> npm ls whatwg-url                                       
└─┬ @sentry/wizard@3.28.0
  └─┬ @sentry/cli@1.77.3
    └─┬ node-fetch@2.7.0
      └── whatwg-url@5.0.0

Actually, even with the newest eslint version, this is still an open issue for anyone using Node 21/22: eslint/eslint#17733.

So looks like we need to resolve this in Sentry CLI 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant