diff --git a/static/app/components/events/highlights/editHighlightsModal.tsx b/static/app/components/events/highlights/editHighlightsModal.tsx index 22f2c606b3c5d2..f7a1d36ef1c06f 100644 --- a/static/app/components/events/highlights/editHighlightsModal.tsx +++ b/static/app/components/events/highlights/editHighlightsModal.tsx @@ -155,10 +155,8 @@ function EditTagHighlightSection({ ...props }: EditTagHighlightSectionProps) { const [tagFilter, setTagFilter] = useState(''); - // filter out replayId because we don't want to expose - // this on issue details anymore const tagData = event.tags - .filter(tag => tag.key?.includes(tagFilter) && tag.key !== 'replayId') + .filter(tag => tag.key?.includes(tagFilter)) .map(tag => tag.key); const tagColumnSize = Math.ceil(tagData.length / columnCount); const tagColumns: React.ReactNode[] = []; @@ -251,17 +249,12 @@ function EditContextHighlightSection({ const ctxItems = Object.entries(ctxData); const filteredCtxItems = ctxItems .map<[string, string[]]>(([contextType, contextKeys]) => { - // filter out replayId because we don't want to expose - // this on issue details anymore const filteredContextKeys = contextKeys.filter( - contextKey => - (contextKey.includes(ctxFilter) || contextType.includes(ctxFilter)) && - contextKey !== 'replay_id' + contextKey => contextKey.includes(ctxFilter) || contextType.includes(ctxFilter) ); return [contextType, filteredContextKeys]; }) .filter(([_contextType, contextKeys]) => contextKeys.length !== 0); - const ctxColumnSize = Math.ceil(filteredCtxItems.length / columnCount); const contextColumns: React.ReactNode[] = []; for (let i = 0; i < filteredCtxItems.length; i += ctxColumnSize) { @@ -338,14 +331,9 @@ export default function EditHighlightsModal({ project, closeModal, }: EditHighlightsModalProps) { - const {replay, ...rest} = prevHighlightContext; - const [highlightContext, setHighlightContext] = useState({ - ...(replay && {replay: replay?.filter(k => k !== 'replay_id')}), - ...rest, - }); - const [highlightTags, setHighlightTags] = useState( - prevHighlightTags.filter(p => p !== 'replayId') - ); + const [highlightContext, setHighlightContext] = + useState(prevHighlightContext); + const [highlightTags, setHighlightTags] = useState(prevHighlightTags); const organization = useOrganization(); diff --git a/static/app/components/events/highlights/highlightsDataSection.tsx b/static/app/components/events/highlights/highlightsDataSection.tsx index 31f8cdf011eb17..f9f5fd8dbb7aa8 100644 --- a/static/app/components/events/highlights/highlightsDataSection.tsx +++ b/static/app/components/events/highlights/highlightsDataSection.tsx @@ -140,16 +140,11 @@ function HighlightsData({ const hasDisabledHighlights = Object.values(highlightContext).flat().length === 0 && highlightTags.length === 0; - const {replay, ...rest} = highlightContext; - const highlightContextDataItems = getHighlightContextData({ event, project, organization, - highlightContext: { - ...(replay && {replay: replay?.filter(k => k !== 'replay_id')}), - ...rest, - }, + highlightContext, location, }); const highlightContextRows = highlightContextDataItems.reduce( @@ -170,10 +165,7 @@ function HighlightsData({ [] ); - const highlightTagItems = getHighlightTagData({ - event, - highlightTags: highlightTags.filter(h => h !== 'replayId'), - }); + const highlightTagItems = getHighlightTagData({event, highlightTags}); const highlightTagRows = highlightTagItems.map((content, i) => (