From 4bf6e389bea64ccdc8cb39ba794caec965e8f9db Mon Sep 17 00:00:00 2001 From: Richard Ortenberg Date: Thu, 10 Aug 2023 11:20:08 -0700 Subject: [PATCH] rename to failure_issue_threshold --- src/sentry/monitors/models.py | 2 +- src/sentry/monitors/validators.py | 2 +- .../monitors/endpoints/test_organization_monitor_index.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sentry/monitors/models.py b/src/sentry/monitors/models.py index 0a760715584d80..b6ea543ef91c0b 100644 --- a/src/sentry/monitors/models.py +++ b/src/sentry/monitors/models.py @@ -62,7 +62,7 @@ "schedule_type": {"type": "integer"}, "schedule": {"type": ["string", "array"]}, "alert_rule_id": {"type": ["integer", "null"]}, - "issue_threshold": {"type": ["integer", "null"]}, + "failure_issue_threshold": {"type": ["integer", "null"]}, "recovery_threshold": {"type": ["integer", "null"]}, }, # TODO(davidenwang): Old monitors may not have timezone or schedule_type, these should be added here once we've cleaned up old data diff --git a/src/sentry/monitors/validators.py b/src/sentry/monitors/validators.py index 10ddedd2acedb8..ad993264b77666 100644 --- a/src/sentry/monitors/validators.py +++ b/src/sentry/monitors/validators.py @@ -108,7 +108,7 @@ class ConfigValidator(serializers.Serializer): help_text="tz database style timezone string", ) - issue_threshold = EmptyIntegerField( + failure_issue_threshold = EmptyIntegerField( required=False, allow_null=True, default=None, diff --git a/tests/sentry/monitors/endpoints/test_organization_monitor_index.py b/tests/sentry/monitors/endpoints/test_organization_monitor_index.py index 484cb62657b4ea..affc38a6b4203b 100644 --- a/tests/sentry/monitors/endpoints/test_organization_monitor_index.py +++ b/tests/sentry/monitors/endpoints/test_organization_monitor_index.py @@ -183,7 +183,7 @@ def test_simple(self, mock_record): "schedule": "0 0 * * *", "checkin_margin": None, "max_runtime": None, - "issue_threshold": None, + "failure_issue_threshold": None, "recovery_threshold": None, }