From 908937d51197120047067471497c4a1249836731 Mon Sep 17 00:00:00 2001 From: Colleen O'Rourke Date: Thu, 31 Aug 2023 10:49:02 -0700 Subject: [PATCH] ref(rules): Return stringified status (#55549) Return the string "active" or "disabled" rather than the enum value. --- src/sentry/api/serializers/models/rule.py | 3 ++- tests/sentry/api/endpoints/test_project_rule_details.py | 2 +- tests/sentry/api/serializers/test_alert_rule.py | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sentry/api/serializers/models/rule.py b/src/sentry/api/serializers/models/rule.py index 342ea7179022bc..0228b52e29d015 100644 --- a/src/sentry/api/serializers/models/rule.py +++ b/src/sentry/api/serializers/models/rule.py @@ -5,6 +5,7 @@ from rest_framework import serializers from sentry.api.serializers import Serializer, register +from sentry.constants import ObjectStatus from sentry.models import ( ACTOR_TYPES, Environment, @@ -175,7 +176,7 @@ def serialize(self, obj, attrs, user, **kwargs): "createdBy": attrs.get("created_by", None), "environment": environment.name if environment is not None else None, "projects": [obj.project.slug], - "status": obj.status, + "status": "active" if obj.status == ObjectStatus.ACTIVE else "disabled", } if "last_triggered" in attrs: d["lastTriggered"] = attrs["last_triggered"] diff --git a/tests/sentry/api/endpoints/test_project_rule_details.py b/tests/sentry/api/endpoints/test_project_rule_details.py index e4eb8aff982fe0..a21c92275b6b7b 100644 --- a/tests/sentry/api/endpoints/test_project_rule_details.py +++ b/tests/sentry/api/endpoints/test_project_rule_details.py @@ -117,7 +117,7 @@ def test_with_environment(self): ) assert response.data["id"] == str(self.rule.id) assert response.data["environment"] == self.environment.name - assert response.data["status"] == ObjectStatus.ACTIVE + assert response.data["status"] == "active" def test_with_filters(self): conditions: list[dict[str, Any]] = [ diff --git a/tests/sentry/api/serializers/test_alert_rule.py b/tests/sentry/api/serializers/test_alert_rule.py index 4af245faf0e897..a4404c4c0c19fa 100644 --- a/tests/sentry/api/serializers/test_alert_rule.py +++ b/tests/sentry/api/serializers/test_alert_rule.py @@ -3,7 +3,6 @@ CombinedRuleSerializer, DetailedAlertRuleSerializer, ) -from sentry.constants import ObjectStatus from sentry.incidents.logic import create_alert_rule_trigger from sentry.incidents.models import AlertRule, AlertRuleThresholdType from sentry.models import Rule @@ -221,6 +220,6 @@ def test_combined_serializer(self): self.assert_alert_rule_serialized(alert_rule, result[0]) assert result[1]["id"] == str(issue_rule.id) - assert result[1]["status"] == ObjectStatus.ACTIVE + assert result[1]["status"] == "active" assert not result[1]["snooze"] self.assert_alert_rule_serialized(other_alert_rule, result[2])