Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Details Page: Provide a UI indication when error stack frames are missing/dropped #61034

Open
idosun opened this issue Dec 4, 2023 · 6 comments
Labels
Product Area: Issues Sync: Jira apply to auto-create a Jira shadow ticket

Comments

@idosun
Copy link

idosun commented Dec 4, 2023

Problem Statement

Sentry SDKs generally limit the number of captured stack frames and apply logic to drop frames often from the middle of the stack (to comply with the event size limits). When I look at an errors stack trace in the issues detail page, Id like to know that it is partial and that frames are missing/dropped.

Solution Brainstorm

No response

Product Area

Issues

┆Issue is synchronized with this Jira Improvement by Unito

@idosun idosun added the Sync: Jira apply to auto-create a Jira shadow ticket label Dec 4, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Dec 4, 2023

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Dec 4, 2023

Routing to @getsentry/product-owners-issues for triage ⏲️

@malwilley
Copy link
Member

@idosun do you have a link to any example issues with this problem? It would be helpful to see what the event data looks like in this case.

@lobsterkatie
Copy link
Member

lobsterkatie commented Dec 4, 2023

This also comes up, for example, in node, where stacktraces are capped at 10 frames by default (not by the SDK, but by node itself). In that case, we could note that and send people to a docs page telling them how to up the limit in node if they so choose.

In any case, the first step here would be to agree upon a standardized way for SDKs to report this. Once we have that, we can talk about UI (and in the meantime the data would then at least be accessible in the event JSON).

@idosun - Since it affects multiple SDKs, this'd be a great thing to either bring to the client infra TSC yourself or get an SDK engineer to bring to the TSC. I'd start with someone who works on whatever SDK this most affects.

@realkosty
Copy link
Contributor

Related: getsentry/relay#3905

@leeandher
Copy link
Member

This isn't currently prioritized but we'd have to work with ingest team to get specific data about omitted frames and their ordering, as that's not available at the moment.

The _meta object attached to events does currently have the total number of frames it received though, which could be a starting point for displaying in the UI.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Area: Issues Sync: Jira apply to auto-create a Jira shadow ticket
Projects
Status: No status
Status: No status
Development

No branches or pull requests

6 participants