From 92764964785146611809ae1c9cb1f6e61bfcefd1 Mon Sep 17 00:00:00 2001 From: Scott Cooper Date: Mon, 23 Sep 2024 12:14:08 -0700 Subject: [PATCH] ref(ui): Remove `qs` imports, not a dependency We do not have `qs` as a direct dependency. It works anyway because we have it as a sub dependency, but we shouldn't import things that aren't dependencies. ``` - "webpack-dev-server#express" depends on it - Hoisted from "webpack-dev-server#express#qs" - Hoisted from "@rsdoctor#webpack-plugin#@rsdoctor#sdk#body-parser#qs" ``` --- .../app/views/insights/queues/components/tables/queuesTable.tsx | 2 +- .../insights/queues/components/tables/transactionsTable.tsx | 2 +- .../newTraceDetails/traceDrawer/details/span/sections/http.tsx | 2 +- .../views/performance/newTraceDetails/traceModels/traceTree.tsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/static/app/views/insights/queues/components/tables/queuesTable.tsx b/static/app/views/insights/queues/components/tables/queuesTable.tsx index cdf110ed865925..58cadff85dcdc9 100644 --- a/static/app/views/insights/queues/components/tables/queuesTable.tsx +++ b/static/app/views/insights/queues/components/tables/queuesTable.tsx @@ -1,7 +1,7 @@ import {Fragment} from 'react'; import styled from '@emotion/styled'; import type {Location} from 'history'; -import qs from 'qs'; +import * as qs from 'query-string'; import GridEditable, { COL_WIDTH_UNDEFINED, diff --git a/static/app/views/insights/queues/components/tables/transactionsTable.tsx b/static/app/views/insights/queues/components/tables/transactionsTable.tsx index 5ebf1daf4fbb8b..df3bb8fd600ee8 100644 --- a/static/app/views/insights/queues/components/tables/transactionsTable.tsx +++ b/static/app/views/insights/queues/components/tables/transactionsTable.tsx @@ -1,7 +1,7 @@ import {Fragment} from 'react'; import styled from '@emotion/styled'; import type {Location} from 'history'; -import qs from 'qs'; +import * as qs from 'query-string'; import GridEditable, { COL_WIDTH_UNDEFINED, diff --git a/static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/http.tsx b/static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/http.tsx index 6a2e484dbd75e0..0be2c90f3a5e3f 100644 --- a/static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/http.tsx +++ b/static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/http.tsx @@ -1,4 +1,4 @@ -import qs from 'qs'; +import * as qs from 'query-string'; import type {RawSpanType} from 'sentry/components/events/interfaces/spans/types'; import {t} from 'sentry/locale'; diff --git a/static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx b/static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx index 50cd137d2eeb67..85dc6ae35ef881 100644 --- a/static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx +++ b/static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx @@ -1,7 +1,7 @@ import type {Theme} from '@emotion/react'; import * as Sentry from '@sentry/react'; import type {Location} from 'history'; -import qs from 'qs'; +import * as qs from 'query-string'; import type {Client} from 'sentry/api'; import type {RawSpanType} from 'sentry/components/events/interfaces/spans/types';