From 09f421ddcba962425eda37fb63097128da628bb4 Mon Sep 17 00:00:00 2001 From: colin-sentry <161344340+colin-sentry@users.noreply.github.com> Date: Thu, 19 Sep 2024 15:11:43 -0400 Subject: [PATCH] fix(eap): re-enable tests and entities now that migrations ran (#6325) We finally got the migrations through, can re-re-enable the tests. --- .../events_analytics_platform/storages/spans_num_attrs.yaml | 2 +- .../events_analytics_platform/storages/spans_str_attrs.yaml | 2 +- tests/web/rpc/test_trace_item_attribute_list.py | 1 - tests/web/rpc/test_trace_item_attribute_values.py | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/snuba/datasets/configuration/events_analytics_platform/storages/spans_num_attrs.yaml b/snuba/datasets/configuration/events_analytics_platform/storages/spans_num_attrs.yaml index c559566710..99e093c1fb 100644 --- a/snuba/datasets/configuration/events_analytics_platform/storages/spans_num_attrs.yaml +++ b/snuba/datasets/configuration/events_analytics_platform/storages/spans_num_attrs.yaml @@ -6,7 +6,7 @@ storage: key: spans_num_attrs set_key: events_analytics_platform -readiness_state: limited +readiness_state: partial schema: columns: diff --git a/snuba/datasets/configuration/events_analytics_platform/storages/spans_str_attrs.yaml b/snuba/datasets/configuration/events_analytics_platform/storages/spans_str_attrs.yaml index 9f6c5e6c16..048a8b6782 100644 --- a/snuba/datasets/configuration/events_analytics_platform/storages/spans_str_attrs.yaml +++ b/snuba/datasets/configuration/events_analytics_platform/storages/spans_str_attrs.yaml @@ -6,7 +6,7 @@ storage: key: spans_str_attrs set_key: events_analytics_platform -readiness_state: limited +readiness_state: partial schema: columns: diff --git a/tests/web/rpc/test_trace_item_attribute_list.py b/tests/web/rpc/test_trace_item_attribute_list.py index 2f53d5fcce..ecb0846e70 100644 --- a/tests/web/rpc/test_trace_item_attribute_list.py +++ b/tests/web/rpc/test_trace_item_attribute_list.py @@ -62,7 +62,6 @@ def setup_teardown(clickhouse_db: None, redis_db: None) -> None: write_raw_unprocessed_events(spans_storage, messages) # type: ignore -@pytest.mark.skip(reason="temporarily disabled to allow a migration to run") @pytest.mark.clickhouse_db @pytest.mark.redis_db class TestTraceItemAttributes(BaseApiTest): diff --git a/tests/web/rpc/test_trace_item_attribute_values.py b/tests/web/rpc/test_trace_item_attribute_values.py index e347c3a7d9..3f400219be 100644 --- a/tests/web/rpc/test_trace_item_attribute_values.py +++ b/tests/web/rpc/test_trace_item_attribute_values.py @@ -84,7 +84,6 @@ def setup_teardown(clickhouse_db: None, redis_db: None) -> None: write_raw_unprocessed_events(spans_storage, messages) # type: ignore -@pytest.mark.skip(reason="temporarily disabled to allow a migration to run") @pytest.mark.clickhouse_db @pytest.mark.redis_db class TestTraceItemAttributes(BaseApiTest):