From 8ee8a8c80ed64a37016265d31c2d8bb159f48fbe Mon Sep 17 00:00:00 2001
From: Lyn Nagara <lyn.nagara@gmail.com>
Date: Thu, 15 Feb 2024 17:04:08 -0800
Subject: [PATCH] feat: Remove unnecessary topic validation (#5555)

This is harmful since it can cause every pod to crash if some
topic configuration is missing, which can worse than an actual
missing topic here.

The ops repo now populates all topics automatically from topicctl data
anyway, so this no longer needs to be manually updated.
---
 snuba/settings/validation.py | 60 ------------------------------------
 1 file changed, 60 deletions(-)

diff --git a/snuba/settings/validation.py b/snuba/settings/validation.py
index 7a773941a1..ca6ba1edbf 100644
--- a/snuba/settings/validation.py
+++ b/snuba/settings/validation.py
@@ -28,66 +28,6 @@ def validate_settings(locals: Mapping[str, Any]) -> None:
             "DEFAULT_STORAGE_BROKERS is deprecated. Use KAFKA_BROKER_CONFIG instead."
         )
 
-    topic_names = {
-        "events",
-        "event-replacements",
-        "transactions",
-        "snuba-commit-log",
-        "snuba-transactions-commit-log",
-        "snuba-sessions-commit-log",
-        "snuba-metrics-commit-log",
-        "cdc",
-        "snuba-metrics",
-        "outcomes",
-        "ingest-sessions",
-        "snuba-queries",
-        "scheduled-subscriptions-events",
-        "scheduled-subscriptions-transactions",
-        "scheduled-subscriptions-sessions",
-        "scheduled-subscriptions-metrics",
-        "scheduled-subscriptions-generic-metrics-sets",
-        "scheduled-subscriptions-generic-metrics-distributions",
-        "scheduled-subscriptions-generic-metrics-counters",
-        "events-subscription-results",
-        "transactions-subscription-results",
-        "sessions-subscription-results",
-        "metrics-subscription-results",
-        "generic-metrics-subscription-results",
-        "processed-profiles",
-        "snuba-attribution",
-        "profiles-call-tree",
-        "ingest-replay-events",
-        "generic-events",
-        "group-attributes",
-        "snuba-generic-events-commit-log",
-        "snuba-dead-letter-replays",
-        "snuba-generic-metrics",
-        "snuba-generic-metrics-sets-commit-log",
-        "snuba-generic-metrics-distributions-commit-log",
-        "snuba-generic-metrics-counters-commit-log",
-        "snuba-dead-letter-generic-metrics",
-        "snuba-dead-letter-sessions",
-        "snuba-dead-letter-metrics",
-        "snuba-dead-letter-metrics-sets",
-        "snuba-dead-letter-metrics-distributions",
-        "snuba-dead-letter-metrics-counters",
-        "snuba-dead-letter-generic-events",
-        "snuba-dead-letter-querylog",
-        "snuba-dead-letter-group-attributes",
-        "snuba-generic-events-commit-log",
-        "snuba-spans",
-        "shared-resources-usage",
-        "snuba-metrics-summaries",
-    }
-
-    for key in locals["KAFKA_TOPIC_MAP"].keys():
-        if key not in topic_names:
-            raise InvalidTopicError(f"Invalid topic value: {key}")
-
-    for key in locals["KAFKA_BROKER_CONFIG"].keys():
-        if key not in topic_names:
-            raise ValueError(f"Invalid topic value {key}")
-
     # Validate cluster configuration
     from snuba.clusters.storage_sets import StorageSetKey