From 94fa31ad53211ac4f6ac596bb44ee561b5f717e1 Mon Sep 17 00:00:00 2001 From: Dalitso Banda Date: Wed, 21 Jun 2023 21:05:23 -0700 Subject: [PATCH] show nodes migration is applied on (#4388) * show nodes migration is applied on * show node type --- snuba/migrations/operations.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/snuba/migrations/operations.py b/snuba/migrations/operations.py index 9ade7bd977..0e9eff44e6 100644 --- a/snuba/migrations/operations.py +++ b/snuba/migrations/operations.py @@ -3,12 +3,16 @@ from enum import Enum from typing import Any, Callable, Mapping, Optional, Sequence, Tuple +import structlog + from snuba.clickhouse.columns import Column from snuba.clusters.cluster import ClickhouseClientSettings, get_cluster from snuba.clusters.storage_sets import StorageSetKey from snuba.migrations.columns import MigrationModifiers from snuba.migrations.table_engines import TableEngine +logger = structlog.get_logger().bind(module=__name__) + class OperationTarget(Enum): """ @@ -49,12 +53,13 @@ def execute(self) -> None: nodes = dist_nodes else: raise ValueError(f"Target not set for {self}") - + if nodes: + logger.info(f"Executing op: {self.format_sql()[:32]}...") for node in nodes: connection = cluster.get_node_connection( ClickhouseClientSettings.MIGRATE, node ) - + logger.info(f"Executing on {self.target.value} node: {node}") connection.execute(self.format_sql(), settings=self._settings) @abstractmethod