From b36448e01a9cfa6b7d923989ba7027d72d3d546b Mon Sep 17 00:00:00 2001 From: Lyn Nagara Date: Thu, 11 Jan 2024 16:15:02 -0800 Subject: [PATCH] fix(rust): Don't produce commit log in --skip-write mode (#5385) --- rust_snuba/src/factory.rs | 2 +- rust_snuba/src/strategies/commit_log.rs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/rust_snuba/src/factory.rs b/rust_snuba/src/factory.rs index 6f4324b831..502c474bce 100644 --- a/rust_snuba/src/factory.rs +++ b/rust_snuba/src/factory.rs @@ -100,7 +100,7 @@ impl ProcessingStrategyFactory for ConsumerStrategyFactory { self.physical_topic_name, self.physical_consumer_group.clone(), &self.commitlog_concurrency, - false, + self.skip_write, )) } else { Box::new(next_step) diff --git a/rust_snuba/src/strategies/commit_log.rs b/rust_snuba/src/strategies/commit_log.rs index b3aaacdfb3..b2c42c97ab 100644 --- a/rust_snuba/src/strategies/commit_log.rs +++ b/rust_snuba/src/strategies/commit_log.rs @@ -167,7 +167,6 @@ pub struct ProduceCommitLog { } impl ProduceCommitLog { - #[allow(dead_code)] pub fn new( next_step: N, producer: Arc + 'static>,