From efa8f8b265c52fb9bba32e3e7e3a3741bb5a54fb Mon Sep 17 00:00:00 2001 From: MeredithAnya Date: Fri, 20 Sep 2024 11:59:23 -0700 Subject: [PATCH] (snuba-deletes): storage_deletes_enabled default enabled (#6331) Makes the default `storage_deletes_enabled=1`. Sentry tests should be testing against this feature. In production all regions except S4S have this set to `0`. Additionally, only the `search_issues` dataset has deletes enabled in the storage configuration. --- snuba/web/delete_query.py | 2 +- tests/test_search_issues_api.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/snuba/web/delete_query.py b/snuba/web/delete_query.py index 6171f86c04..57b3d08ae7 100644 --- a/snuba/web/delete_query.py +++ b/snuba/web/delete_query.py @@ -125,7 +125,7 @@ def _delete_from_table( def deletes_are_enabled() -> bool: - return bool(get_config("storage_deletes_enabled", 0)) + return bool(get_config("storage_deletes_enabled", 1)) def _get_rows_to_delete( diff --git a/tests/test_search_issues_api.py b/tests/test_search_issues_api.py index 9261a78d1f..f180c9638b 100644 --- a/tests/test_search_issues_api.py +++ b/tests/test_search_issues_api.py @@ -198,7 +198,6 @@ def test_bad_delete(self) -> None: assert "'query' is a required property" in res.get_json()["error"]["message"] # test for invalid column types - set_config("storage_deletes_enabled", 1) res = self.app.delete( "/search_issues/", data=json.dumps(