From 8e0819b786134eb96f23229dbfc4f786fcee999a Mon Sep 17 00:00:00 2001 From: Colin Chartier Date: Wed, 11 Sep 2024 19:25:03 -0400 Subject: [PATCH] fix: store event ID (it is not in tags) --- rust_snuba/src/processors/eap_spans.rs | 3 +++ ...ust_snuba__processors__eap_spans__tests__serialization.snap | 1 + ...PSpansMessageProcessor-snuba-spans__1__basic_span.json.snap | 3 +++ 3 files changed, 7 insertions(+) diff --git a/rust_snuba/src/processors/eap_spans.rs b/rust_snuba/src/processors/eap_spans.rs index a78181e4a6..2a7a6458b5 100644 --- a/rust_snuba/src/processors/eap_spans.rs +++ b/rust_snuba/src/processors/eap_spans.rs @@ -133,6 +133,9 @@ impl From for EAPSpan { attr_num_buckets[(fnv_1a(k.as_bytes()) as usize) % attr_num_buckets.len()] .insert(k.clone(), v); }; + if let Some(event_id) = from.event_id { + insert_string("sentry.event_id".into(), event_id.to_string()) + } if let Some(sentry_tags) = from.sentry_tags { sentry_tags.iter().for_each(|(k, v)| { diff --git a/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_spans__tests__serialization.snap b/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_spans__tests__serialization.snap index 05eac7c04f..bbcadcbe62 100644 --- a/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_spans__tests__serialization.snap +++ b/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_spans__tests__serialization.snap @@ -71,6 +71,7 @@ expression: span }, "attr_str_12": { "relay_use_post_or_schedule_rejected": "version", + "sentry.event_id": "d826225d-e75d-42d6-b2f0-1b957d51f18f", "server_name": "D23CXQ4GK2.local" }, "attr_str_13": { diff --git a/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-spans-EAPSpansMessageProcessor-snuba-spans__1__basic_span.json.snap b/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-spans-EAPSpansMessageProcessor-snuba-spans__1__basic_span.json.snap index 64a32b2761..83500c0ecb 100644 --- a/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-spans-EAPSpansMessageProcessor-snuba-spans__1__basic_span.json.snap +++ b/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-spans-EAPSpansMessageProcessor-snuba-spans__1__basic_span.json.snap @@ -14,6 +14,9 @@ expression: snapshot_payload "tag3": "True", "transaction.op": "navigation" }, + "attr_str_12": { + "sentry.event_id": "dcc403b7-3ef5-4864-8188-bbfa6012e9dc" + }, "attr_str_18": { "tag1": "value1" },