From 5e51d6cd99a0af1e4f6000b806edf7da4acfe2e8 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Wed, 21 Aug 2024 12:57:24 +0200 Subject: [PATCH] really fix it now? --- .../overlay/src/integrations/sentry/data/sentryDataCache.ts | 2 +- packages/overlay/src/integrations/sentry/index.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/overlay/src/integrations/sentry/data/sentryDataCache.ts b/packages/overlay/src/integrations/sentry/data/sentryDataCache.ts index 28b75d34..6b2e343d 100644 --- a/packages/overlay/src/integrations/sentry/data/sentryDataCache.ts +++ b/packages/overlay/src/integrations/sentry/data/sentryDataCache.ts @@ -44,7 +44,7 @@ class SentryDataCache { initial.forEach(e => this.pushEvent(e)); } - setSidecarUrl(url: string) { + setSidecarUrl(url: string | null) { if (!url) { this.contextLinesProvider = null; return; diff --git a/packages/overlay/src/integrations/sentry/index.ts b/packages/overlay/src/integrations/sentry/index.ts index 69413e2c..60ea31b8 100644 --- a/packages/overlay/src/integrations/sentry/index.ts +++ b/packages/overlay/src/integrations/sentry/index.ts @@ -31,6 +31,8 @@ export default function sentryIntegration(options: SentryIntegrationOptions = {} } if (options.sidecarUrl) { sentryDataCache.setSidecarUrl(options.sidecarUrl); + } else if ('sidecarUrl' in options) { + sentryDataCache.setSidecarUrl(null); } addSpotlightIntegrationToSentry(options);