Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolicate runtime types for Flutter web events #807

Open
Tracked by #897
marandaneto opened this issue Jul 24, 2023 · 3 comments
Open
Tracked by #897

Symbolicate runtime types for Flutter web events #807

marandaneto opened this issue Jul 24, 2023 · 3 comments

Comments

@marandaneto
Copy link

marandaneto commented Jul 24, 2023

Relates to dart-lang/sdk#53027

The event.exceptions[x].type is minified and is used to create the Issue's titles on Sentry.
Issue's title now looks like this: minified:rT instead of Exception which is the demangled version of rT.

Screenshot 2023-07-24 at 15 14 41

The Flutter web source maps contain extensions that allow the demangling of such runtime types.

https://github.com/dart-lang/sdk/blob/master/pkg/compiler/doc/sourcemap_extensions.md#minified-names-data

The goal of this issue would be to demangle also the exception types for better Issue titles.

This can also be used to demangle View hierarchy that heavily depends on the runtime types.

As you can see the note:

Deobfuscation for view hierarchies is fully supported for native SDKs, and React Native, but is currently not supported for Flutter.

Consider making it generic that the demangling of runtime types can be used for Errors but not only.

@loewenheim
Copy link
Contributor

This would require a number of changes in our stack.

  • rust-sourcemap needs to support a custom sourcemap extension.
  • symbolic needs to support this extension.
  • Symbolicator needs to know about the exception type when symbolicating. I.e. the structure of what gets sent to Symbolicator must change.

All of this is eminently doable, but it's no small effort and requires careful consideration.

@jernejstrasner jernejstrasner changed the title Symbolicate runtime types for Flutter web events [Epic] Symbolicate runtime types for Flutter web events Feb 21, 2024
@jernejstrasner jernejstrasner changed the title [Epic] Symbolicate runtime types for Flutter web events Symbolicate runtime types for Flutter web events Feb 21, 2024
@Fraa-124
Copy link

any update on this?

@loewenheim
Copy link
Contributor

Sorry, we haven't been working on this. It's still at the "maybe, at some point" stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants