Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 123.0.2420.53 is fucking me again #4

Open
lingsamuel opened this issue Mar 26, 2024 · 15 comments
Open

Version 123.0.2420.53 is fucking me again #4

lingsamuel opened this issue Mar 26, 2024 · 15 comments

Comments

@lingsamuel
Copy link

lingsamuel commented Mar 26, 2024

The flag is gone AGAIN. I truly suspect this is caused by their version control, some branches have it and some branches don't.

I try to use this program to start edge, but it hangs for 10 min+, it is still hanging. 20 mins.
I guess latest edge breaks something again.

Update:
Using command line flag --disable-features=msWindowTabManagerPublic in the shortcut do the same thing as the old flag.

@gexgd0419
Copy link
Owner

Version 123.0.2420.65 and this flag is still missing.

The latest release of this program works on my system. If you are using an older release, make sure that there's no Edge processes running in the background.

@lingsamuel
Copy link
Author

lingsamuel commented Mar 30, 2024

I am using latest release. This works, I just need to wait for a long time. About 20+ mins.
The browser is unresponsive during the time.

@bobsage123
Copy link

I haven't noticed any slowdowns and i'm not using your program this time around. I wonder if they attempted some kind of fix? Granted I am using sub 1000 (~950) tabs right now so I don't if that's enough for the issue to be noticeable.

@bobsage123
Copy link

I am also experiencing the slowness on the latest build as well even with using this app with now over 1100 tabs.

I'm sitting at about 9000 GDI objects on explorer.exe

When I check processexplorer and go to the threads, it is showing the vast majority of them are ntdll.dll!RtlClearThreadWorkOnBehalfTicket+0x70.

I'm not sure if the above is relevant for this.

@gexgd0419
Copy link
Owner

Does the msedge process still load the module Windows.Internal.UI.Shell.WindowTabManager.dll, which is the component this program is trying to block?

@bobsage123
Copy link

Does the msedge process still load the module Windows.Internal.UI.Shell.WindowTabManager.dll, which is the component this program is trying to block?

I am not sure how to check that. Would it be under threads in process explorer for the main edge.exe?

@gexgd0419
Copy link
Owner

In Process Explorer, make the lower pane show DLLs, then select the main msedge process and check the DLL list.

@bobsage123
Copy link

Looks like it is.

image

@gexgd0419
Copy link
Owner

So in your case it failed to block the component.

This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.

If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.

If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

@bobsage123
Copy link

So in your case it failed to block the component.

This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.
If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.
If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

I just did another fully shutdown of Edge and it seemed to work this time.

The previous time where it did not work I believe I had all edge processes closed, but the previous shutdown was not clean and I had to "restore" the tabs. Unsure if that may have caused it to return?

@L0ngMarch
Copy link

So in your case it failed to block the component.

This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.
If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.
If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

Your program works for me temporarily! It really helps me a lot, thx! This problem cause me crazy, hope that MS can fix this.

@github1328
Copy link

The previous time where it did not work I believe I had all edge processes closed, but the previous shutdown was not clean and I had to "restore" the tabs. Unsure if that may have caused it to return?

Is that a thing? My edge just updated, flag is gone and problem is back.
I can't get it to work if I'm restoring a session, like you said. Otherwise I think it worked, but the browser crashed for some reason.

@bobsage123
Copy link

The previous time where it did not work I believe I had all edge processes closed, but the previous shutdown was not clean and I had to "restore" the tabs. Unsure if that may have caused it to return?

Is that a thing? My edge just updated, flag is gone and problem is back. I can't get it to work if I'm restoring a session, like you said. Otherwise I think it worked, but the browser crashed for some reason.

I'm not sure, I have to test the next time it happens. But it seems the most reliable way for this to work is if the previous edge shutdown did not crash and you don't have to "restore" tabs on startup.

@gexgd0419
Copy link
Owner

Hi! Here's a new release version: v0.4.

This version (finally) can work automatically no matter how Edge is started, if you choose to register it as an IFEO debugger.

@lingsamuel
Copy link
Author

lingsamuel commented Jul 11, 2024

I found a (temp) solution in the reddit thread, commandline flag --disable-features=msWindowTabManagerPublic works perfectly. I use this in the taskbar shortcut.

Update: It did work at first, but I noticed that gdi objects was growing during use. I guess this is because edge creates new processes without the flag. I actually can't find the flag in any edge processes in Task Manager -> Command line. And they never seem to recycle any gdi objects. I have ~600 tabs and ~4500 gdi objects now. The gdi objects number was ~900 without edge and still ~900 after launched with ~500 tabs.

I also found that they do more than gdi objects stuff. I can feel a very obviously performance degrade when the active tabs reach 200 or 300. In browser task manager, the "browser" itself is consuming nearly 100% CPU almost all the time. The browser also takes minutes to launch, even with the "fix" program in this repo.

But before 123.0.2420.53, I could start Edge with ~1500 tabs in seconds. I can also have thousands of active tabs without significant performance issue.

I have to try to rollback the edge version to fix my life😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants