You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is yielding different results than rasterio's default statistics() methods and gives the wrong max value for rgb_geotiff.tiff specifically which is set in the unit tests:
The true max value for this file is 240, not 212. Setting bApproxOK=False gives the correct value of 240.
I think we probably want to dynamically choose bApproxOK based on the overall size of the image. If its smaller than some threshold, use bApproxOK=False to get the true value and if it's over some threshold, use bApproxOK=True for efficiency.
The text was updated successfully, but these errors were encountered:
GetStatistics()
with GDAL currently usesbApproxOK=True
andbForce=True
. We should evaluate if these are the best choices (see https://gdal.org/doxygen/classGDALRasterBand.html#a6aa58b6f0a0c17722b9bf763a96ff069)large_image/sources/gdal/large_image_source_gdal/__init__.py
Line 582 in 2bcc4f0
This is yielding different results than
rasterio
's defaultstatistics()
methods and gives the wrongmax
value forrgb_geotiff.tiff
specifically which is set in the unit tests:large_image/test/test_source_gdal.py
Line 70 in 2bcc4f0
The true
max
value for this file is240
, not212
. SettingbApproxOK=False
gives the correct value of240
.I think we probably want to dynamically choose
bApproxOK
based on the overall size of the image. If its smaller than some threshold, usebApproxOK=False
to get the true value and if it's over some threshold, usebApproxOK=True
for efficiency.The text was updated successfully, but these errors were encountered: