From d4dc0efd7d4b71acadae61f619b9e84f97d15c83 Mon Sep 17 00:00:00 2001 From: Ramsay Jones Date: Sat, 31 Aug 2024 15:58:56 +0100 Subject: [PATCH] compat/terminal: mark parameter of git_terminal_prompt() UNUSED If neither HAVE_DEV_TTY nor GIT_WINDOWS_NATIVE is set, the fallback code calls the system getpass(). This unfortunately ignores the "echo" boolean parameter, as we have no way to implement that functionality. But we still have to keep the unused parameter, since our interface has to match the other implementations. Co-authored-by: Jeff King Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano --- compat/terminal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/terminal.c b/compat/terminal.c index 0afda730f278cc..d54efa1c5d6ebf 100644 --- a/compat/terminal.c +++ b/compat/terminal.c @@ -594,7 +594,7 @@ void restore_term(void) { } -char *git_terminal_prompt(const char *prompt, int echo) +char *git_terminal_prompt(const char *prompt, int echo UNUSED) { return getpass(prompt); }