Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent labeling of Note/Warning blocks #35195

Closed
1 task done
akordowski opened this issue Nov 5, 2024 · 10 comments
Closed
1 task done

Inconsistent labeling of Note/Warning blocks #35195

akordowski opened this issue Nov 5, 2024 · 10 comments
Labels
content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs

Comments

@akordowski
Copy link
Contributor

akordowski commented Nov 5, 2024

Code of Conduct

What article on docs.github.com is affected?

Reading the GitHub Actions documentation I have noticed that the labeling of Note/Warning blocks is inconsistent through the documentation. Is that intentional or can be this seen as a bug?

>[!NOTE]

note_1

**Note:** or **Notes:**

note_2

note_3

>[!WARNING]

warning_1

**Warning:**

warning_2

What part(s) of the article would you like to see updated?

My first search in the repository indicates that it affects other docs as well. It would be nice if the docs would have a consistent way to display the blocks (preferably the >[!NOTE] / >[!WARNING] notation), and not have different kinds even in same article.

Additional information

If whished I could provide a PR to fix this issue.

@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Nov 5, 2024
Copy link

welcome bot commented Nov 5, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 5, 2024
@nguyenalex836 nguyenalex836 added contributing docs Content related to our contributing docs and removed triage Do not begin working on this issue until triaged by the team labels Nov 5, 2024
@nguyenalex836
Copy link
Contributor

@akordowski Thank you for catching this inconsistency! ✨ Notes and warnings should be consistent with the formatting laid out by our style guide 💛

Please feel free to open a PR to update this whenever you have a chance - thank you!

@Piyush-r-bhaskar
Copy link
Contributor

Piyush-r-bhaskar commented Nov 6, 2024

Hi @akordowski

I would like to fix this inconsistency. Would it be fine for you if I take this one if you are not already about to open a PR.

Thanks

@akordowski
Copy link
Contributor Author

@Piyush-r-bhaskar I already started with the work, so maybe next time.

@akordowski
Copy link
Contributor Author

PR is available #35216. This was lot of work 😌

@akordowski
Copy link
Contributor Author

@nguyenalex836 I have further questions for clarification.

  1. There were several cases where the docs contained alerts as the following example:

    {% tip %}
    **Note:** description
    {% endtip %}
    
    // or
    
    {% warning %}
    **Note:** description
    {% endwarning %}
    
    // or other combinations

    For this cases I always prefered the prefix (**Note:**) for the Markdown notation (> [!NOTE]) over the liquid ({% tip %}) notation. Is that correct?

  2. And there are cases where the docs contain alerts without any prefix in the description:

    {% note %}
    Descriiption
    {% endnote %}

    These cases I didn't changed and kept them as the are. Is that correct or should I change them to the corresponding Markdown notation (> [!NOTE]) as well?

Looking forward for your feedback. Thank you!

@nguyenalex836
Copy link
Contributor

@akordowski 👋

For this cases I always prefered the prefix (Note:) for the Markdown notation (> [!NOTE]) over the liquid ({% tip %}) notation. Is that correct?

Great catch - yes, this is correct! ✨ A snippet from our style guide confirms this -

Liquid syntax for alerts is still supported and may still appear in older articles, but should not be used for new alerts.


And there are cases where the docs contain alerts without any prefix in the description

Go ahead and leave leave those as they are - good call 💛

@akordowski
Copy link
Contributor Author

@nguyenalex836 As discussed I splited the original PR #35216 into 4 new ones:

I will close the original PR.

@nguyenalex836
Copy link
Contributor

Given the final PR in this series has been merged, I'll go ahead and close this issue ✨

An incredible undertaking by @akordowski - thank you so much for lending your time and expertise to our community 💛

@akordowski
Copy link
Contributor Author

@nguyenalex836 It was my pleasure! Thank you also for your time to review all the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants