-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent labeling of Note/Warning blocks #35195
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@akordowski Thank you for catching this inconsistency! ✨ Notes and warnings should be consistent with the formatting laid out by our style guide 💛 Please feel free to open a PR to update this whenever you have a chance - thank you! |
Hi @akordowski I would like to fix this inconsistency. Would it be fine for you if I take this one if you are not already about to open a PR. Thanks |
@Piyush-r-bhaskar I already started with the work, so maybe next time. |
PR is available #35216. This was lot of work 😌 |
@nguyenalex836 I have further questions for clarification.
Looking forward for your feedback. Thank you! |
Great catch - yes, this is correct! ✨ A snippet from our style guide confirms this -
Go ahead and leave leave those as they are - good call 💛 |
@nguyenalex836 As discussed I splited the original PR #35216 into 4 new ones:
I will close the original PR. |
Given the final PR in this series has been merged, I'll go ahead and close this issue ✨ An incredible undertaking by @akordowski - thank you so much for lending your time and expertise to our community 💛 |
@nguyenalex836 It was my pleasure! Thank you also for your time to review all the changes. |
Code of Conduct
What article on docs.github.com is affected?
Reading the GitHub Actions documentation I have noticed that the labeling of
Note/Warning
blocks is inconsistent through the documentation. Is that intentional or can be this seen as abug
?What part(s) of the article would you like to see updated?
My first search in the repository indicates that it affects other docs as well. It would be nice if the docs would have a consistent way to display the blocks (preferably the
>[!NOTE] / >[!WARNING]
notation), and not have different kinds even in same article.Additional information
If whished I could provide a PR to fix this issue.
The text was updated successfully, but these errors were encountered: