Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhandled exceptions kill server #41

Open
jaked opened this issue Jun 21, 2024 · 0 comments
Open

unhandled exceptions kill server #41

jaked opened this issue Jun 21, 2024 · 0 comments

Comments

@jaked
Copy link
Collaborator

jaked commented Jun 21, 2024

e.g. this code in a cell

import * as Domain from "node:domain";

const d = Domain.create();
const p = d.run(async () => {
  throw new Error("test");
});

throws a server-killing exception, I think because the promise isn't awaited in the code path that handles exceptions. I think there's a top-level exception handler we need to set, and also we need to clean up the cell execution state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant