Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option for delimiter #5

Open
mgillam opened this issue Feb 16, 2018 · 1 comment
Open

No option for delimiter #5

mgillam opened this issue Feb 16, 2018 · 1 comment

Comments

@mgillam
Copy link

mgillam commented Feb 16, 2018

Using this within a node application, I hit a case where I wanted to concatenate multiple files together without inserting a linebreak between them (it's for reassembling a single piece of data spread across files). Currently the newline is hard-coded. I fixed it in my local build by hacking the change into the package, but maybe it would be worthwhile including an option to either omit the \n or take it a step further by allowing the user to supply a delimiter string, much like the join method on an array. Obviously this would be an optional parameter with the default behavior being identical to current behavior.
To be clear, I don't mind doing the work and submitting a PR if I've got agreement on the change.

@alexchandel
Copy link

The README should mention that concat concatenates with newlines interspersed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants