Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Slack installed from dl.flathub.org #13

Open
olibre opened this issue Jun 5, 2019 · 4 comments
Open

Compatibility with Slack installed from dl.flathub.org #13

olibre opened this issue Jun 5, 2019 · 4 comments

Comments

@olibre
Copy link

olibre commented Jun 5, 2019

Hi, thank you for your awesome project.

I am using Fedora 29 with GNOME and I have installed Slack using the application GNOME Software that downloads a flatpak package from https://flathub.org/apps/details/com.slack.Slack

I have successfully patched ssb-interop.js and index.js files. But when I restart Slack, I do not see the "Plugins" section at the bottom (below Advance) within the Preferences page...

In order to use your project, must I install Slack for Linux only from https://slack.com/intl/en-fr/downloads/linux ?

My detailed adventure:

$ git clone https://github.com/glajchs/slack-customizations.gitCloning into 'slack-customizations'...
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 367 (delta 3), reused 8 (delta 3), pack-reused 359
Receiving objects: 100% (367/367), 427.93 KiB | 1.25 MiB/s, done.
Resolving deltas: 100% (244/244), done.

$ cd slack-customizations; ./patch-slack.sh
cat: /usr/lib/slack/resources/app.asar.unpacked/src/static/ssb-interop.js: No such file or directory
Patching Slack's ssb-interop.js file at /usr/lib/slack/resources/app.asar.unpacked/src/static/ssb-interop.js
[sudo] password for olibre:
tee: /usr/lib/slack/resources/app.asar.unpacked/src/static/ssb-interop.js: No such file or directory
cat: /usr/lib/slack/resources/app.asar.unpacked/src/static/index.js: No such file or directory
Patching Slack's index.js file at /usr/lib/slack/resources/app.asar.unpacked/src/static/index.js
tee: /usr/lib/slack/resources/app.asar.unpacked/src/static/index.js: No such file or directory

$ locate ssb-interop.js
/var/lib/flatpak/app/com.slack.Slack/x86_64/stable/5eb3cfc6d38e11671e0f1ee0640f696c4ae198339e90c3cae3b075e054a0d0fd/files/extra/lib/slack/resources/app.asar.unpacked/src/static/ssb-interop.js

$ SLACK_INSTALLATION_PATH=/var/lib/flatpak/app/com.slack.Slack/x86_64/stable/5eb3cfc6d38e11671e0f1ee0640f696c4ae198339e90c3cae3b075e054a0d0fd/files/extra/lib/slack/resources ./patch-slack.sh
Patching Slack's ssb-interop.js file at /var/lib/flatpak/app/com.slack.Slack/x86_64/stable/5eb3cfc6d38e11671e0f1ee0640f696c4ae198339e90c3cae3b075e054a0d0fd/files/extra/lib/slack/resources/app.asar.unpacked/src/static/ssb-interop.js
Patching Slack's index.js file at /var/lib/flatpak/app/com.slack.Slack/x86_64/stable/5eb3cfc6d38e11671e0f1ee0640f696c4ae198339e90c3cae3b075e054a0d0fd/files/extra/lib/slack/resources/app.asar.unpacked/src/static/index.js
ln: failed to create symbolic link '/home/olibre/.slack/slack-customizations': File exists

$ file /home/olibre/.slack/slack-customizations
/home/olibre/.slack/slack-customizations: symbolic link to /home/olibre/dev/github/slack-customizations
@olibre
Copy link
Author

olibre commented Jun 5, 2019

I have just downloaded and installed Slack 3.4.2 64-bit from
https://slack.com/intl/en-fr/downloads/instructions/fedora

But the same issue: there is not "Plugins" section at the bottom (below Advance) within the Preferences page...

Therefore this does not seems to be an issue about flatpak package. Maybe this is due to the recent version 3.4.2 ?

Is there a trick to enable the "Plugins" section?

Best wishes

@mjyousse
Copy link

@olibre Same issue here. Did anyone find a solution? Thank you

@willpower232
Copy link

Flatpak (and Snap) may not have access to your home directory by default so you have to make sure slack is installed normally.

Also you may find that Flatpak (or Snap) undo the changes you've made or otherwise aren't writable.

@glajchs
Copy link
Owner

glajchs commented Jul 23, 2019

Sorry I'm so late in responding to this. My patch script looks for slack in the default location installed via the package manager. I would say you should just manually patch the files where they are located (find via locate like you did above), however Slack 4.0.0 just came out and totally broke everything. I'm still trying to figure out how to work w/4.0, and when I do, I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants