Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to the build matrix #2

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

chris-allan
Copy link
Member

.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR builds wheel artifacts as expected but the Python library fails to load a runtime error due to the removal of imp in Python 3.12:

sbesson@Sebastiens-MacBook-Pro-3 artifacts % python --version
Python 3.12.1
sbesson@Sebastiens-MacBook-Pro-3 artifacts % python -mvenv venv
sbesson@Sebastiens-MacBook-Pro-3 artifacts % venv/bin/pip install zeroc_ice-3.6.5-cp312-cp312-macosx_11_0_universal2.whl 
Processing ./zeroc_ice-3.6.5-cp312-cp312-macosx_11_0_universal2.whl
Installing collected packages: zeroc-ice
Successfully installed zeroc-ice-3.6.5

[notice] A new release of pip is available: 23.2.1 -> 23.3.2
[notice] To update, run: /Users/sbesson/Downloads/artifacts/venv/bin/python -m pip install --upgrade pip
sbesson@Sebastiens-MacBook-Pro-3 artifacts % venv/bin/python -c 'import Ice'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/sbesson/Downloads/artifacts/venv/lib/python3.12/site-packages/Ice.py", line 14, in <module>
    import sys, string, imp, os, threading, warnings, datetime
ModuleNotFoundError: No module named 'imp'

Minimally, this will need a Python 3.12 additional patch similar to the one proposed in glencoesoftware/zeroc-ice-py-linux-x86_64#3.

With the patch above, I have built a wheel locally on OSX (Intel) and I have used it successfully in my testing of ome/omero-py#390 for the last few weeks.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested the three new artifacts on OSX 14.3 (Intel), by creating virtual environments, installing the wheel package as well as a development version of OMERO.py and running a few basic commands (omero login, omero import, omero delete and omero hql).

Everything worked as expected. Proposing to get that in and cut a new release of the binaries that we can start pointing at for the OMERO Python 3.12 testing

@chris-allan chris-allan merged commit a22946f into glencoesoftware:master Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants