From fb0c011a1d964606553165d087b7922e93784a4f Mon Sep 17 00:00:00 2001 From: Carifio24 Date: Thu, 19 Sep 2024 00:07:30 -0400 Subject: [PATCH 1/2] Update default values for export options. --- glue_ar/common/scatter_export_options.py | 4 ++-- glue_ar/common/volume_export_options.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/glue_ar/common/scatter_export_options.py b/glue_ar/common/scatter_export_options.py index 1849d68..4cc1db9 100644 --- a/glue_ar/common/scatter_export_options.py +++ b/glue_ar/common/scatter_export_options.py @@ -7,8 +7,8 @@ class ARVispyScatterExportOptions(State): - theta_resolution = CallbackProperty(8) - phi_resolution = CallbackProperty(8) + theta_resolution = CallbackProperty(10) + phi_resolution = CallbackProperty(10) class ARIpyvolumeScatterExportOptions(State): diff --git a/glue_ar/common/volume_export_options.py b/glue_ar/common/volume_export_options.py index 1e593a7..cef8d3b 100644 --- a/glue_ar/common/volume_export_options.py +++ b/glue_ar/common/volume_export_options.py @@ -10,5 +10,5 @@ class ARIsosurfaceExportOptions(State): class ARVoxelExportOptions(State): - opacity_cutoff = CallbackProperty(0.05) - opacity_resolution = CallbackProperty(0.01) + opacity_cutoff = CallbackProperty(0.1) + opacity_resolution = CallbackProperty(0.02) From 740430f54eb6ff4bc451e2d93108d19b34449b19 Mon Sep 17 00:00:00 2001 From: Carifio24 Date: Thu, 19 Sep 2024 00:17:17 -0400 Subject: [PATCH 2/2] Update tests to match. --- glue_ar/qt/tests/test_tool_scatter.py | 4 ++-- glue_ar/qt/tests/test_tool_volume.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/glue_ar/qt/tests/test_tool_scatter.py b/glue_ar/qt/tests/test_tool_scatter.py index effa53e..c2d1f54 100644 --- a/glue_ar/qt/tests/test_tool_scatter.py +++ b/glue_ar/qt/tests/test_tool_scatter.py @@ -91,5 +91,5 @@ def test_tool_export_call(self, extension, compression): assert len(value) == 2 assert value[0] == "Scatter" assert isinstance(value[1], ARVispyScatterExportOptions) - assert value[1].theta_resolution == 8 - assert value[1].phi_resolution == 8 + assert value[1].theta_resolution == 10 + assert value[1].phi_resolution == 10 diff --git a/glue_ar/qt/tests/test_tool_volume.py b/glue_ar/qt/tests/test_tool_volume.py index 69f3352..c81b772 100644 --- a/glue_ar/qt/tests/test_tool_volume.py +++ b/glue_ar/qt/tests/test_tool_volume.py @@ -96,8 +96,8 @@ def test_tool_export_call(self, extension, compression): scatter_method, scatter_state = state_dict["Scatter Data"] assert scatter_method == "Scatter" assert isinstance(scatter_state, ARVispyScatterExportOptions) - assert scatter_state.theta_resolution == 8 - assert scatter_state.phi_resolution == 8 + assert scatter_state.theta_resolution == 10 + assert scatter_state.phi_resolution == 10 volume_method, volume_state = state_dict["Volume Data"] assert volume_method == "Isosurface"