Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop runtime dependency on setuptools #2511

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −5
Draft

DEP: drop runtime dependency on setuptools #2511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions glue/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ def load_plugins(splash=None, require_qt_plugins=False, plugins_to_load=None):
# where ``setup`` is a function that does whatever is needed to set up the
# plugin, such as add items to various registries.

import setuptools
logger.info("Loading external plugins using "
"setuptools=={0}".format(setuptools.__version__))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep 'Loading external plugins' - just don't give the setuptools version

logger.info("Loading external plugins")

from glue._plugin_helpers import iter_plugin_entry_points, PluginConfig
config = PluginConfig.load()
Expand Down
1 change: 0 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ install_requires =
echo>=0.6
astropy>=4.0
fast_histogram>=0.12
setuptools>=30.3.0
ipython>=4.0
dill>=0.2
h5py>=2.10; python_version<'3.11'
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ deps =
legacy: pandas==1.2.*
legacy: echo==0.5.*
legacy: astropy==4.0.*
legacy: setuptools==30.3.*
legacy: setuptools==30.3.* # required by mpl-scatter-density
legacy: ipython==7.16.*
legacy: ipykernel==5.3.*
legacy: dill==0.2.*
Expand Down
Loading