From f736debd817634e7b045e3483cceea129846d906 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Robles=20Mart=C3=ADn?= Date: Fri, 3 Dec 2021 23:16:00 +0100 Subject: [PATCH] chore: clarify how to get internal NLB (#2356) * chore: specify how to get classic nlb type Adding clarifications about the current annotation "service.beta.kubernetes.io/aws-load-balancer-type: external" as it sounds confusing and does not show that an "internal" NLB can be achieved using that type. * Move deprecation note to line start * add tip about provisioning internal lb * fix: only nlb can be provisioned * chore: change to Internet-facing Co-authored-by: Steven E. Harris * Update docs/guide/service/annotations.md * Update docs/guide/service/annotations.md * Update docs/guide/service/annotations.md Co-authored-by: Steven E. Harris Co-authored-by: Steven E. Harris Co-authored-by: Kishor Joshi --- docs/guide/service/annotations.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/guide/service/annotations.md b/docs/guide/service/annotations.md index 4ff1d83cc..b7af98429 100644 --- a/docs/guide/service/annotations.md +++ b/docs/guide/service/annotations.md @@ -62,9 +62,12 @@ Traffic Routing can be controlled with following annotations: - `service.beta.kubernetes.io/aws-load-balancer-type` specifies the load balancer type. This controller reconciles those service resources with this annotation set to either `nlb-ip` or `external`. + !!!tip + This annotation specifies the controller used to provision LoadBalancers (as specified in [legacy-cloud-provider](#legacy-cloud-provider)). Refer to [lb-scheme](#lb-scheme) to specify whether the LoadBalancer is internet-facing or internal. + !!!note "" - - For `nlb-ip` type, controller will provision NLB with IP targets. This value is supported for backwards compatibility - - For `external` type, NLB target type depend on the annotation [nlb-target-type](#nlb-target-type) + - [Deprecated] For type `nlb-ip`, the controller will provision an NLB with targets registered by IP address. This value is supported for backwards compatibility. + - For type `external`, the NLB target type depends on the [nlb-target-type](#nlb-target-type) annotation. !!!warning "limitations" - This annotation should not be modified after service creation.