-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unmatched single quotes produce incorrect highlighting #1
Comments
@daveriedstra Oh yep that looks off to me too. It's been years since I've done anything with Faust or this plugin, which is mostly a copy-paste from the Faust repo with some minor improvements. A pull request would be deeply appreciated if you have the time, it might be a while before I can get to it but I'll try soon. Would you mind linking me to that example? There's a few instances of the prime syntax on the Faust website but it'd be nice to have more. |
The example is from agraef's pd-faustgen fork:
https://github.com/agraef/pd-faustgen/blob/faustgen2/external/examples/karplus.dsp
I'll take a look at doing a PR, no promises it'll be good though lol
…On Wed., Sep. 23, 2020, 19:58 Griffin Moe, ***@***.***> wrote:
@daveriedstra <https://github.com/daveriedstra> Oh yep that looks off to
me too. It's been years since I've done anything with Faust or this plugin,
which is mostly a copy-paste from the Faust repo with some minor
improvements. A pull request would be deeply appreciated if you have the
time, it might be a while before I can get to it but I'll try soon.
Would you mind linking me to that example? There's a few instances of the
prime syntax on the Faust website but it'd be nice to have more.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2XPYSHT2KQJCU2XI6MZJLSHKDTVANCNFSM4RXQZBOQ>
.
|
@daveriedstra Oddly I don't have that issue, which Vim theme are you using? I want to try it locally to make sure there's nothing about my theme hiding behavior. I'd also double-check that your environment is using the plugin, because there aren't any highlighters in this plugin that match single-quote regions. I've at least made some improvements to other parts of the highlighter at least, trying to fix some of the things I broke in the process. |
@daveriedstra I'm doing some major refactoring of the plugin for better highlighting and supporting more syntax like |
Single quotes are treated as if they need to be matched, which throws off the syntax highlighting.
(New to Faust, but that code is from an example in some repo -- forgive me if that's not actually correct syntax!)
The text was updated successfully, but these errors were encountered: