Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmatched single quotes produce incorrect highlighting #1

Open
daveriedstra opened this issue Sep 23, 2020 · 4 comments
Open

unmatched single quotes produce incorrect highlighting #1

daveriedstra opened this issue Sep 23, 2020 · 4 comments

Comments

@daveriedstra
Copy link

Single quotes are treated as if they need to be matched, which throws off the syntax highlighting.

image

(New to Faust, but that code is from an example in some repo -- forgive me if that's not actually correct syntax!)

@gmoe
Copy link
Owner

gmoe commented Sep 23, 2020

@daveriedstra Oh yep that looks off to me too. It's been years since I've done anything with Faust or this plugin, which is mostly a copy-paste from the Faust repo with some minor improvements. A pull request would be deeply appreciated if you have the time, it might be a while before I can get to it but I'll try soon.

Would you mind linking me to that example? There's a few instances of the prime syntax on the Faust website but it'd be nice to have more.

@daveriedstra
Copy link
Author

daveriedstra commented Sep 24, 2020 via email

@gmoe
Copy link
Owner

gmoe commented Sep 26, 2020

@daveriedstra Oddly I don't have that issue, which Vim theme are you using? I want to try it locally to make sure there's nothing about my theme hiding behavior.

I'd also double-check that your environment is using the plugin, because there aren't any highlighters in this plugin that match single-quote regions. I've at least made some improvements to other parts of the highlighter at least, trying to fix some of the things I broke in the process.

@gmoe
Copy link
Owner

gmoe commented Oct 11, 2020

@daveriedstra I'm doing some major refactoring of the plugin for better highlighting and supporting more syntax like soundfile and waveform primitives. I would be curious if the dev branch would help solve your issue, it's still a work in progress but should generally support everything the plugin did before with some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants