-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vismia laurentii not found #60
Comments
It is a limitation we currently have. In old literature, the specific epithet is often capitalized. I did try to make capitalization optional in name finding, but it did cause an explosion of false positives. So we do not recognize capitalized epithets yet. It is possible to add an enhancement to bhlindex where we go over all generic occurrences and see if the next capitalized name can be interpreted as a specific epithet. I have this in plans, but not in the near future. If the name is written according to current rules, it is recognized:
|
I think now that we have https://app.swaggerhub.com/apis-docs/dimus/gnmatcher/1.0.0 it may be doable to verify every capitalized epithet. I will try to add it for the next version of gnfinder |
The following feedback was received from a BHL user:
"Hi You seem to have missed Vismia laurentii from your index and I can't search for it as a species only as a phrase. I had to look up the original description in the journal: https://www.biodiversitylibrary.org/item/206854#page/471/mode/1up There is also another description of a variety on this page: https://www.biodiversitylibrary.org/page/36210317#page/69/mode/1up"
Testing gnfinder with the text found at https://www.biodiversitylibrary.org/pagetext/36210317 and https://www.biodiversitylibrary.org/pagetext/50875791, I have confirmed that "Vismia laurentii" is not identified. In both cases, the name does appear correctly in the text, although in both cases "Laurentii" is capitalized.
The text was updated successfully, but these errors were encountered: