Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad View Function Name #519

Open
fleupold opened this issue Feb 3, 2020 · 1 comment
Open

Bad View Function Name #519

fleupold opened this issue Feb 3, 2020 · 1 comment
Labels
Version2 Proposals for the version 2 contract

Comments

@fleupold
Copy link
Contributor

fleupold commented Feb 3, 2020

This method should be called getEncodedOrdersPaginated

dex-contracts/contracts/BatchExchange.sol

Line 479 in cc4c230

function getEncodedUsersPaginated(address previousPageUser, uint16 previousPageUserOffset, uint16 pageSize)

It's not worth renaming and redeploying for that matter (renaming without redeploying might cause incompatibilities with dependent infrastructure pieces). However, it should be fixed in case we need to redeploy again.
@fleupold fleupold mentioned this issue Feb 17, 2020
Open
@anxolin
Copy link
Contributor

anxolin commented Apr 7, 2020

What about creating a git tag for accumulating ideas to evaluate in case of a redeployment?

@fleupold fleupold added the Version2 Proposals for the version 2 contract label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Version2 Proposals for the version 2 contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fleupold @anxolin