Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functions management in DB #3007

Closed
Tracked by #2879
EPajares opened this issue Apr 6, 2024 · 2 comments
Closed
Tracked by #2879

Fix functions management in DB #3007

EPajares opened this issue Apr 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@EPajares
Copy link
Collaborator

EPajares commented Apr 6, 2024

No description provided.

@nihar1024 nihar1024 added the bug Something isn't working label Apr 23, 2024
@EPajares EPajares added this to the v2.0 milestone Jul 30, 2024
@nihar1024
Copy link

init_functions.py mostly looks good to me.

There are a few changes we could consider making:

  • Drop function only if it exists locally (this could help prevent the accidental deletion of functions not created from within goat-core)
  • Some functions are defined in goat-routing, these are not recreated by the script
  • find_unapplied_dependencies() relies on a function's actual name being consistent with the function's filename. However, this is not always the case (e.g. fix_transmeridian_h3(), get_h3_neighbors())

@nihar1024
Copy link

Relevant changes have been submitted here:

goat-community/goat-core#41
goat-community/goat-routing#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants