Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocektpool: RPL formatting / decimal placement incorrect #1413

Open
blinc117 opened this issue Jul 7, 2022 · 3 comments
Open

Rocektpool: RPL formatting / decimal placement incorrect #1413

blinc117 opened this issue Jul 7, 2022 · 3 comments

Comments

@blinc117
Copy link

blinc117 commented Jul 7, 2022

When attempting to make an API call to retrieve the staked RPL amount for a validator the results come back formatted in correctly, not accouting for the 18 decimal places set in the RPL Smart Contract

Examples:
curl -X 'GET' \ 'https://beaconcha.in/api/v1/rocketpool/validator/388862' \ -H 'accept: application/json'
{ "status": "OK", "data": { "index": 388862, "minipool_address": "0x194d3a5a7e203098afabad157bed2117038660c9", "minipool_deposit_type": "Half", "minipool_node_fee": 0.15, "minipool_status": "Staking", "minipool_status_time": 1652072178, "node_address": "0x0eb166575436c2187fc28ae1415941108769a416", "node_max_rpl_stake": 7.32187607697091e+21, "node_min_rpl_stake": 488125071798060650000, "node_rpl_stake": 1.4986317519945715e+21, "node_timezone_location": "America/New_York" } }

https://beaconcha.in/api/v1/rocketpool/validator/388862
{"status":"OK","data":{"index":388862,"minipool_address":"0x194d3a5a7e203098afabad157bed2117038660c9","minipool_deposit_type":"Half","minipool_node_fee":0.15,"minipool_status":"Staking","minipool_status_time":1652072178,"node_address":"0x0eb166575436c2187fc28ae1415941108769a416","node_max_rpl_stake":7321876076970909685894,"node_min_rpl_stake":488125071798060645726,"node_rpl_stake":1498631751994571478801,"node_timezone_location":"America/New_York"}}

@Buttaa
Copy link
Member

Buttaa commented May 2, 2023

Will be considered in our v2 api!

2 similar comments
@Buttaa
Copy link
Member

Buttaa commented May 2, 2023

Will be considered in our v2 api!

@Buttaa
Copy link
Member

Buttaa commented May 2, 2023

Will be considered in our v2 api!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants