underscore in numbers

[r6m]

ruby had this nice feature to add underscore between digits for numbers 1_000_000_000
it would be great if goby can do it too.

[st0012]

@rezam90 yep I think this is a good idea, thanks!

[st0012]

@shes50103 are you willing to try this?

[SD10]

@st0012 Does this involve the parser or only Lexer?

Anyone looking to make this change this is a good place to start:

goby/compiler/lexer/lexer.go

Line 267 in b6a1996

func (l *Lexer) readNumber() []rune {

[st0012]

@SD10 good point, I think this can be done either in lexer or parser, not sure in which one will be simpler though

[SD10]

Yeah, I was thinking of a lazy solution though. I think it would be better to store the original value of the token and do this work in both the Lexer and the Parser. You were right

Here is where someone would need to turn 1_000_000 -> 1000000 in the Parser

goby/compiler/parser/data_type_parsing.go

Line 12 in c00ad0c

func (p *Parser) parseIntegerLiteral() ast.Expression {

[st0012]

@SD10 it seems that you're quite familiar with the components related to this feature, want to give it a try?

[SD10]

If no one else claims it then sure
What do you think about supporting other forms of numeric literal syntax?

1.2e-3                      # Float
0xaabb                    # (Hexadecimal) Fixnum
0b001001               # (Binary) Fixnum
0377                       # (Octal) Fixnum

[st0012]

I think we need to support all of them, but not right now

[shes50103]

ok, I can do it!