Skip to content

Commit

Permalink
Update instructions & upgrade versions
Browse files Browse the repository at this point in the history
  • Loading branch information
dunnkers committed Feb 12, 2024
1 parent 49aa6c5 commit d0b1dc0
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ jobs:

steps:
- name: Checkout (GitHub)
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and run dev container task
uses: devcontainers/ci@v0.2
uses: devcontainers/ci@v0.3
with:
imageName: ghcr.io/${{ github.repository }}/devcontainer
runCmd: echo "Success"
6 changes: 3 additions & 3 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ jobs:

steps:
- name: Checkout (GitHub)
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and run dev container task
uses: devcontainers/ci@v0.2
uses: devcontainers/ci@v0.3
with:
imageName: ghcr.io/${{ github.repository }}/devcontainer
runCmd: pytest .
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2022 GoDataDriven
Copyright (c) 2024 Xebia Data

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Then, there's 2 options:

1. Click _Use this template_ to create a new repo.

<a href="https://github.com/godatadriven/python-devcontainer-template/generate"><img alt="use this template GitHub button" src="https://camo.githubusercontent.com/523d7e81c3d3dcd01b711f14c87e850edeb8e62bf72814d3231ab084a0c70d31/68747470733a2f2f7777772e726f737472756d2e626c6f672f706f73742f323031392d30362d31312d612d7265706f2d74656d706c6174652d666f722d722d616e616c797369735f66696c65732f7573652d746869732e706e67" width="150px" /></a>
<a href="https://github.com/godatadriven/python-devcontainer-template/generate"><img alt="use this template GitHub button" src="https://github.com/godatadriven/python-devcontainer-template/assets/744430/8cb7bc77-af79-41cd-b9da-5625e7ba843e" width="150px" /></a>

1. **Clone** the repo and open it in **VSCode**.

Expand All @@ -42,7 +42,7 @@ That's it 🙌🏻 Enjoy developing.

### Using the button

Another option is to open this repo in VSCode right away. Press the following button:
Another option is to open this repo in VSCode using a special _link_. Press the following button:

[![Open in Remote - Containers](https://img.shields.io/static/v1?label=Remote%20-%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/godatadriven/python-devcontainer-template)

Expand All @@ -62,4 +62,4 @@ This repo was mentioned at the following places:
---


Created by [Jeroen Overschie](https://www.github.com/dunnkers), working at [GoDataDriven](https://godatadriven.com/). A leading Data and AI consultancy company in The Netherlands
Created by [Jeroen Overschie](https://www.github.com/dunnkers), working at [Xebia Data](https://xebia.com/). A leading Data and AI consultancy company in The Netherlands.

0 comments on commit d0b1dc0

Please sign in to comment.