-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy for contributing more plugins #10
Comments
@akien-mga I think we should come up with some way to include new plugins into this repo, but I'm not really sure how to make it work. |
It's mostly up to you as maintainer, but IMO we can add more first-party plugins here which give access to native iOS APIs, as long as the implementation seems easy enough to maintain. We can also aim to grow the team of maintainers of iOS plugins here to ensure that it's manageable. Plugins for third-party APIs should likely stay separate and distributed via community repositories. |
btw. I put the plugin now in a GitHub repo, we can migrate it whenever we want: https://github.com/extrawurst/godot-ios-impact-plugin |
@akien-mga got it, thanks :) @extrawurst I'll wait for your PR then. And don't forget to modify |
@naithar I have a question though, where do I need to add documentation for whatever api I am adding? can't find that in here. |
For now every plugin has it's own README file with description and API, ex: https://github.com/godotengine/godot-ios-plugins/blob/master/plugins/apn/README.md. But if you have any idea how to make it work better, I'm open to suggestions. |
I wrote a plugin now that allows access to iOS native api
UIImpactFeedbackGenerator
(nicer haptics than regular vibration). I was wondering whether this might be something worth adding to the official plugins repo since it is only giving access to iOS native API and no third party stuff.if this is welcomed I can make it a PR.
The text was updated successfully, but these errors were encountered: