-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang binary missing vendored openssl fips patches. #186
Comments
The setup-initial-patch.sh script only generates the patches. They must be applied separately. full-initialize-repo.sh will do both. We should clarify this in the readme. Happy to leave the issue open until then. |
Very sorry, that was a copy paste error in the original post. I meant to type
LEt me update my initial comment also. |
Ah! One thing to note, the symbol names have changed with the inclusion of the golang-fips/openssl@v2 backend in Go 1.22. I don't think that's the issue though if |
Yep. we were hoping for some output. After my last post, I installed glibc-static on my build host and got one match
Full output of full-initialize-repo.sh and make.bash
|
@dbenoit17 @derekparker Let me know if you need any other information. I think for some reason the openssl library is NOT getting linked to make.bash which is why we dont see the openssl patches in the final go binary (maybe some cgo issue). I just cant seem to pin point the issue. maybe its a config issue or a platform issue and NOT a golang-fips script issue. working on this for a couple of weeks now without making any progress , so thought maybe should ask for help. |
@sipasing this is due to the following upstream change: https://go-review.googlesource.com/c/go/+/454836. This means that only Regardless, this is something we should consider reverting within this repo. Note that we do end up reverting this change in our downstream RHEL builds. |
oh interesting. When we tested with RHEL 8.9 and RHEL 8.10 beta from OpenELA , linkage issue was seen. I tried reverting the patch and yes that in fact fixes the linkage problem. I poked inside the patch, and instead of reverting the entire patch, if instead i set the toolenv to CGO_ENABLED=1 in
That also works. Although not an efficient solution, but just thought should share. |
I am building golang v1.22.0 in fips mode on linux by applying patches provided by this repo.
But when i run go tool , I dont see vendored openssl code inside them.
Previous go version i built (go v1.20.12) used to show all vendored openssl-fips cgo symbols.
Am i missing some recent configuration change that is required ?
The text was updated successfully, but these errors were encountered: