Running linter with go mod replaced dependencies behaves differently in CI vs local causing typecheck errors

[bbq2100]

Hi!

I am observing an unexpected behavior when running the linter locally vs in the CI (Jenkins).

Context: Unfortunately I need to replace some dependencies since those are not fetchable in the CI

replace (
	github.com/gabriel-vasile/mimetype v1.4.3 => ./vendored/mimetype
	github.com/klauspost/compress v1.17.8 => ./vendored/compress
)

Running the same cmd

docker run --rm \
	-v $(abspath .):$(abspath .) -w $(abspath .) \
	golangci/golangci-lint:v1.59.1 golangci-lint run

works locally (osx 14.5) but not in the CI (linux), where I am getting typecheck errors saying that the same types from the vendored deps are undefined although go mod verify is fine and I am able to go build and run go tests in the CI.

e.g.

internal/utils/validation_errors.go:12:23: undefined: validator (typecheck)
 	var validationErrors validator.ValidationErrors

Weirdly, when vendoring all dependencies via go mod vendor, the above command works also in the CI context.

So far I tried out following options:

• GO111MODULE=on GOFLAGS=-mod=mod
• using different Container versions
• --modules-download-mode=readonly

Any pointers would be appreciated!

Go env CI

GO111MODULE=''
 GOARCH='amd64'
 GOBIN=''
 GOCACHE='/root/.cache/go-build'
 GOENV='/root/.config/go/env'
 GOEXE=''
 GOEXPERIMENT=''
 GOFLAGS=''
 GOHOSTARCH='amd64'
 GOHOSTOS='linux'
 GOINSECURE=''
 GOMODCACHE='/go/pkg/mod'
 GONOPROXY=''
 GONOSUMDB=''
 GOOS='linux'
 GOPATH='/go'
 GOPRIVATE=''
 GOPROXY='https://proxy.golang.org,direct/'
 GOROOT='/usr/local/go'
 GOSUMDB='sum.golang.org'
 GOTMPDIR=''
 GOTOOLCHAIN='auto'
 GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
 GOVCS=''
 GOVERSION='go1.22.4'
 GCCGO='gccgo'
 GOAMD64='v1'
 AR='ar'
 CC='gcc'
 CXX='g++'
 CGO_ENABLED='1'
 GOMOD='/var/lib/jenkins/workspace/<>/go.mod'
 GOWORK=''
 CGO_CFLAGS='-O2 -g'
 CGO_CPPFLAGS=''
 CGO_CXXFLAGS='-O2 -g'
 CGO_FFLAGS='-O2 -g'
 CGO_LDFLAGS='-O2 -g'
 PKG_CONFIG='pkg-config'
 GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4084180139=/tmp/go-build -gno-record-gcc-switches'

Go env local

docker run -t --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.59.1 go env
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_arm64'
GOVCS=''
GOVERSION='go1.22.4'
GCCGO='gccgo'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/app/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2002917859=/tmp/go-build -gno-record-gcc-switches'

[ldez]

Hi,

the way you vendor the dependencies is not standard (you are using a folder named vendored), this can be the root of your problem.

I think you should use a standard approach by using Go workspace.