Using importas linter to require no alias to be provided for certain packages

[denisvmedia]

I used this configuration to guarantee errors package having no alias:

      - pkg: errors
        alias: ""

Now, I discovered that some colleagues are adding an alias to the someinternalpkg/log package (which is not desired). I decided to expand the configuration:

      - pkg: errors
        alias: ""
      - pkg: someinternalpkg/log
        alias: ""

But it leads to the following problem:

ERRO [linters_context] invalid configuration, multiple packages with the same alias: alias= packages=[someinternalpkg/log,errors]

Is it possible to achieve this using importas (or alternatively any other linter)?

To me not giving an alias should not be considered as a duplicate alias.

[ldez]

Hello,

I think you can use:

linters-settings:
  importas:
    # Do not allow non-required aliases.
    # Default: false
    no-extra-aliases: true

https://golangci-lint.run/usage/linters/#importas

$ golangci-lint run
importas.go:3:8: import "fmt" has alias "koo" which is not part of config (importas)
import koo "fmt"
       ^

[denisvmedia]

But then it would force all packages not mentioned in config to not have aliases, which would not work for our huge and old project.

Note, we also have no-unaliased: true.

[ldez]

🤔 I will see what I can do.

[denisvmedia]

I can try to provide a PR, if you think this is something we can allow in the linter.

[ldez]

I have a fix

[ldez]

#5222

[ccoVeille]

I'm discovering the feature you mentioned it's very interesting

      - pkg: errors
        alias: ""
      - pkg: someinternalpkg/log
        alias: ""

I checked and this was possible without the

• importas: allow multiple empty aliases #5222

      - pkg: errors|someinternalpkg/log
        alias: ""

This was also possible

      - pkg: errors
        alias: "errors"
      - pkg: someinternalpkg/log
        alias: "log"

But, I do prefer the solution @ldez provided

[denisvmedia]

This was also possible

Actually, this didn't work the way you would expect. It would force you to have these aliases (if you have no-unaliased: true) or will allow both: aliased and non-aliased imports (which is also undesirable for us).

[ccoVeille]

Indeed