Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new requests #62

Open
45 tasks
bgaillard opened this issue Oct 20, 2016 · 2 comments
Open
45 tasks

Implement new requests #62

bgaillard opened this issue Oct 20, 2016 · 2 comments

Comments

@bgaillard
Copy link
Member

bgaillard commented Oct 20, 2016

Recently Pushwoosh updated its Remote Guide API documentation, version 2.x.x of the library should progressively implement the new requests.

@curtisgibby
Copy link
Contributor

Any idea when this might be implemented? I'd love to have access to the getUnregisteredDevices method directly using this library.

@bgaillard
Copy link
Member Author

Hi @curtisgibby, we're sorry to not be very reactive since several months on this project. We have too much work to do on other projects :).

If you want you can create a PR we'll review, implementing a new request is not too complex because we've clearly organize the source code to make this very easy.

WARNING Please always use the develop branch for your PR and never the master branch (this is because we use the Gitflow workflow).

Here are the steps to follow to implement a new request

  • First create a new request class in src/main/php/Gomoob/Pushwoosh/Model/Request and the associated Unit Test class in src/main/php/Gomoob/Pushwoosh/Model/Request
  • Then create the associated response in src/main/php/Gomoob/Pushwoosh/Model/Response and the associated unit test class in src/test/php/Gomoob/Pushwoosh/Model/Response
  • Add the new method in src/main/php/Gomoob/Pushwoosh/IPushwoosh.php, src/main/php/Gomoob/Pushwoosh/Client/Pushwoosh.php and src/main/php/Gomoob/Pushwoosh/Client/PushwooshMock.php
  • Add a complete unit test in for your new method in src/test/php/Gomoob/Pushwoosh/Client/PushwooshTest.php

Finally for the getUnregisteredDevices we'll perhaps need a new Model\Device package and a new Device class.

If you can please take an extreme care about the documentation, I think this is what makes the API easy to understand, use and update by other developers.

Do not hesitate if you have other questions.

Hope you'll have the time to develop this ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants