Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves Code Climate rating on the Notification class #9

Open
bgaillard opened this issue Jan 19, 2015 · 0 comments
Open

Improves Code Climate rating on the Notification class #9

bgaillard opened this issue Jan 19, 2015 · 0 comments
Assignees
@bgaillard
Labels
enhancement
Milestone
2.0.0

Comments

@bgaillard
Copy link
Member

Currently the Gomoob\Pushwoosh\Model\Notification\Notification class has an F note on Code Climate. This is bad and we have to fix it.

See https://codeclimate.com/github/gomoob/php-pushwoosh/src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php.

See also https://codeclimate.com/changelog/5670481aac74390098001828 because the Notification class has no design problems.
@bgaillard bgaillard self-assigned this Jan 19, 2015
@bgaillard bgaillard added this to the 1.0.1 milestone Jan 19, 2015
@bgaillard bgaillard modified the milestones: 1.0.5, 1.0.1 Apr 16, 2015
@bgaillard bgaillard modified the milestones: 1.0.5, 1.0.6, 1.1.7 Apr 26, 2015
@bgaillard bgaillard modified the milestones: 1.1.0, 1.0.7 Jun 18, 2015
@bgaillard bgaillard modified the milestones: 1.2.0, 1.3.0 Nov 25, 2015
@bgaillard bgaillard modified the milestones: 1.4.0, 1.3.0 Dec 28, 2015
@bgaillard bgaillard modified the milestones: 1.5.0, 1.6.0 Feb 15, 2016
@bgaillard bgaillard removed this from the 1.8.0 milestone Oct 20, 2016
@bgaillard bgaillard modified the milestones: 2.0.0, 1.8.0 Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgaillard bgaillard

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@bgaillard