Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Julia API when installed in /usr/local #497

Closed
lanctot opened this issue Feb 11, 2021 · 2 comments · Fixed by #506
Closed

Problem with Julia API when installed in /usr/local #497

lanctot opened this issue Feb 11, 2021 · 2 comments · Fixed by #506

Comments

@lanctot
Copy link
Collaborator

lanctot commented Feb 11, 2021

Hi @findmyway, we had to move our CI away from Travis and to Github Actions this week. The problem is that the Julia tests are now failing again, see here: https://github.com/jblespiau/open_spiel-1/runs/1595264912?check_suite_focus=true

The problem is similar to #201 except the command I used before no longer works because I copied the library to the $HOME/packages/julias/julia-1.3.1. See here: https://github.com/deepmind/open_spiel/blob/32a3d303e0ce710f2ef70a3214d26640cde97bf7/open_spiel/scripts/install.sh#L197

Now the machines have Julia installed in /usr/local/julia1.5.3, and this might generally happen on the user side. So we'll probably need to do a sudo to copy the file. I think we can do this in our install script as long as we echo something like why we requiring sudo... but even if that works, it does not feel like an elegant solution. Do you have a better idea about how to fix this?

@findmyway
Copy link
Collaborator

Hi @lanctot ,

I think we don't need to copy the library with Julia (and CxxWrap) of the latest version. The required change should be minor but I need to verify it first. (My response may be slow due to the Chinese New Year 😃 )

@lanctot
Copy link
Collaborator Author

lanctot commented Feb 11, 2021

Great. Happy Chinese New Year!

No rush on this. We have disabled the Julia API in all of our tests until we can figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants