Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dtype do not need to match params dtype but only grads dtype a priori #1098

Open
vroulet opened this issue Oct 9, 2024 · 0 comments
Assignees

Comments

@vroulet
Copy link
Collaborator

vroulet commented Oct 9, 2024

Revise #1060 in light of the discussion of #1039.
Namely, make tests ensure that dtype of grads is preserved (not necessarily the same as the dtype of params for e.g. mixed precision training).
Revise the patch #1060 to see if the initialization of the dtypes in the states are too stringent or not.

@vroulet vroulet self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant