Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing # in metrics.py #6

Open
qsyao opened this issue Aug 6, 2020 · 1 comment
Open

missing # in metrics.py #6

qsyao opened this issue Aug 6, 2020 · 1 comment

Comments

@qsyao
Copy link

qsyao commented Aug 6, 2020

def _crop_to_bounding_box(mask, bbox_min, bbox_max):
"""Crops a 2D or 3D mask to the bounding box specified by bbox_{min,max}."""

we need to zeropad the cropped region with 1 voxel at the lower,

the right (and the back on 3D) sides. This is required to obtain the

"full" convolution result with the 2x2 (or 2x2x2 in 3D) kernel.

TODO: This is correct only if the object is interior to the

bounding box.

cropmask = np.zeros((bbox_max - bbox_min) + 2, np.uint8)

TODO ......

alexdaniel654 added a commit to alexdaniel654/surface-distance that referenced this issue Dec 2, 2020
@veritas9872
Copy link

This is still unfixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants