Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on submodules to specify the rust toolchain #261

Closed
ia0 opened this issue Jan 18, 2021 · 1 comment · Fixed by #663
Closed

Do not rely on submodules to specify the rust toolchain #261

ia0 opened this issue Jan 18, 2021 · 1 comment · Fixed by #663
Assignees
Labels
enhancement New feature or request

Comments

@ia0
Copy link
Member

ia0 commented Jan 18, 2021

We currently use a symlink to specific the rust-toolchain based on what is used by libtock-rs. This is problematic for github workflows that don't need to clone the submodules since they would use the stable toolchain instead of nightly (and the same version as libtock).

The current proposal solution is to have a copy of the libtock rust-toolchain file instead of a symlink. The CI check executed when bumping libtock should check that the file is in sync.

Once this is fixed, we should clean-up github workflows that force the toolchain to nightly to workaround this issue (e.g. .github/workflows/persistent_store_test.yml).

@ia0 ia0 added the enhancement New feature or request label Jan 18, 2021
@kaczmarczyck kaczmarczyck linked a pull request Nov 9, 2023 that will close this issue
@kaczmarczyck
Copy link
Collaborator

With #663, the rust-toolchain will be declared in the base directory.

The comment about workflows is obsolete.

@kaczmarczyck kaczmarczyck self-assigned this Nov 9, 2023
@kaczmarczyck kaczmarczyck reopened this Nov 9, 2023
@kaczmarczyck kaczmarczyck linked a pull request Nov 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants