Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request message eliding doesn't respect @OutputOnly fields #61

Open
imjasonh opened this issue Oct 13, 2015 · 0 comments
Open

Request message eliding doesn't respect @OutputOnly fields #61

imjasonh opened this issue Oct 13, 2015 · 0 comments

Comments

@imjasonh
Copy link

A method that takes a path parameter called "foo" and a request body with a field called "foo" has the request message and path parameter elided, assuming that the value of "foo" specified in the request body will be the same one that should be specified in the path.

This ignores the case where the "foo" field in the request body is marked as @OutputOnly, where it's not valid to pass the value in the request body.

--unelidable_request_methods can specify that the message should not be elided, but ideally the eliding logic would skip eliding messages when @OutputOnly is involved.

I believe the necessary change is somewhere in _NeedRequestType here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant